fix(gatsby): do not fail in develop when eslint loader is removed #28494
+11
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
vladar
added
topic: webpack/babel
vladar
changed the title
pieh
pushed a commit
that referenced
this pull request
Dec 7, 2020
) (cherry picked from commit b3c171f)
pieh
pushed a commit
that referenced
this pull request
Dec 7, 2020
) (#28517) (cherry picked from commit b3c171f) Co-authored-by: Vladimir Razuvaev <[email protected]>
|
Published in |
pragmaticpat
pushed a commit
to pragmaticpat/gatsby
that referenced
this pull request
Apr 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug when
gatsby developbreaks in the unfortunate (and very rare) edge case when theeslintloader is removed from the webpack config (in site'sonCreateWebpackConfig).Before this PR we assume eslint loader always exists. This PR removes this assumption and makes the failing code more robust.
Related Issues
Fixes #28429