[do not merge] Preview of experimental minidisc-ffwd branch#10
Draft
thp wants to merge 170 commits intogavinbenda:masterfrom
Draft
[do not merge] Preview of experimental minidisc-ffwd branch#10thp wants to merge 170 commits intogavinbenda:masterfrom
thp wants to merge 170 commits intogavinbenda:masterfrom
Conversation
The duration value includes a "hours" field which needs to be read and added to the minutes returned. For reference, Web Minidisc / netmd-js properly reads 4 values and gets the value right (the USB command seems to be slightly different, but in any case, Web Minidisc shows the proper duration in its UI). https://github.com/cybercase/netmd-js/blob/edc2401ea1840cecaeea42339b243f37109f8ece/src/netmd-interface.ts#L728
Author
If it's needed, it can always be dug out from Git history.
Patch by @aaronamm over at the netmd-js project: cybercase/netmd-js#40
The configuration of the first frame is supposed to be stored as "reference configuration", not to be overwritten by some default parameters.
Currently, the value assigned to fragtype is never written to disc. The value written to disk is zero, and that's the correct value.
implements the missing (but likely useless) feature to create fragments with a non-zero type. This feature is implemented, so the write code is consistent with the read code.
This bug was introduced by 1f06890.
Remove duplicated raw message for move command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview of proposed changes. Feel free to cherry-pick what you can use already now.