Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add windows installation #32

Closed
wants to merge 81 commits into from
Closed

Add windows installation #32

wants to merge 81 commits into from

Conversation

mabelzhang
Copy link
Contributor

Partially addresses gazebosim/docs#117

I haven't added a tutorial page to address this other issue gazebosim/docs#14 (comment) , since ign-tools is "tricky"? Do we want a tutorial page for it?

nkoenig and others added 30 commits February 13, 2019 08:20
@nkoenig
Updating to use ignition cmake 2
71cab10
@nkoenig
No coverage right now
4cdf430
@nkoenig
Disable codecheck for now
6950194
@nkoenig
Install and require yaml
0323977
@nkoenig
trying python-yaml to fix pipelines
bb6b38e
@nkoenig
Merged from default
0547ca9
@scpeters
CMakeLists.txt: bump to 0.2.0
1bbee03
@scpeters
add configure.bat that builds ign-cmake2
1c5ec13
@scpeters
configure.bat: install libyaml
c86b8ea
@scpeters
gtest: hide gcc pragmas from windows
b1820c3
@scpeters
fix gtest diff
f75e069
@scpeters
increase cmake required version to 3.10.2 to match ign-cmake2
fb01d85
Revert find dependencies
1895ef7
@nkoenig
Adding include directory so that cmake variables work correctly
163b572
@scpeters
don't need to install yaml files
511b153
@nkoenig
Remove strings.h
1491e87
@nkoenig
Bump to 1.0.0
d821f07
@chapulina
Fix pipelines
92da894
@chapulina
disable clang-tidy for now
423da9f
@caguero
Accepting multiple paths in IGN_CONFIG_PATH.
fdf3f84
@chapulina
Close branch pipelines_cmake2
cd549d7
@chapulina
Merged in pipelines_cmake2 (pull request #12)
9c69cc3 
Fix pipelines

Approved-by: Carlos Agüero <[email protected]>
@chapulina
Close branch ign_config_multipath
6189e8c
@chapulina
Merged in ign_config_multipath (pull request #13)
e15bdff 
[Blueprint] Accepting multiple paths in IGN_CONFIG_PATH

Approved-by: Louise Poubel <[email protected]>
@caguero
Merge from ign_config_multipath_0
80c3bb8
@caguero
Bump to 1.0.0
6a10c84
@caguero
Renaming project to ign-tools1.
bc0bd26
@caguero
Merge from default.
d8106c5
@nkoenig
Updates
ac17015
@nkoenig
No coverage on pipeline
7dc8ebe
chapulina and others added 5 commits August 5, 2020 14:47
@chapulina
0 ➡️ 1 (#24)
eb5167d 
Signed-off-by: Louise Poubel <[email protected]>
@caguero
Add ruby style checker (#25)
6c6ed6a 
* Use rubocup as style checker.

Signed-off-by: Carlos Agüero <[email protected]>

* Adding rubocop

Signed-off-by: Carlos Agüero <[email protected]>

* Inspect ign.in

Signed-off-by: Carlos Agüero <[email protected]>
@chapulina
Improve fork experience (#29)
6232765 
Signed-off-by: Louise Poubel <[email protected]>
@Pro
fix: Use PACKAGE_PREFIX_DIR to ensure relocatable CMake install for c…
96f7ebd 
…onan (#30)

Signed-off-by: Stefan Profanter <[email protected]>
@mabelzhang
add windows installation
88ea910 
Signed-off-by: Mabel Zhang <[email protected]>
@mabelzhang mabelzhang requested a review from caguero as a code owner December 24, 2020 04:43
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome labels Dec 24, 2020
@mabelzhang mabelzhang added the Windows Windows support label Dec 24, 2020
@mabelzhang
formatting
a2d8502 
Signed-off-by: Mabel Zhang <[email protected]>
@chapulina chapulina added the documentation Improvements or additions to documentation label Dec 28, 2020
JShep1
JShep1 reviewed Dec 29, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
JShep1
JShep1 reviewed Dec 29, 2020
View reviewed changes
Copy link

@JShep1 JShep1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, also we should likely include the binary installation for windows, the install command is conda install libignition-tools --channel conda-forge

Also, do you know how to use the actual command line tooling? I found ign residing in my conda environment's Library/bin but it doesn't seem to be executable. I'll try to look into this more next week.

@mabelzhang
Copy link
Contributor Author

mabelzhang commented Jan 8, 2021 •
edited
Loading

This library's tutorial is one of the very different ones from the rest... It didn't have a binary install section. If we add binary instruction for Windows, we should add it for Ubuntu too, else it'd look like we don't have a Ubuntu binary package for it. I wasn't sure whether to just revamp the whole thing or follow what's there.

This week, it sounds like we're gonna try to make them all the same, so I went in and did some shelving in efbcf3c, to make it consistent with the formatting in ign-common and ign-math. Since there's so much diff already, I thought I might as well run dos2unix on it, because the end lines looked very weird in diffs in the Linux terminal. So... GitHub is gonna mark the whole file as different.

I haven't tried the ign command either.

@mabelzhang mabelzhang changed the base branch from ign-tools1 to ign-tools0 January 8, 2021 00:56
@mabelzhang
typo
8ced867 
Signed-off-by: Mabel Zhang <[email protected]>
@mabelzhang
Copy link
Contributor Author

mabelzhang commented Jan 8, 2021 •
edited
Loading

I'm going to close and reopen another PR. The rebasing onto Citadel has too many conflicts.

@mabelzhang mabelzhang closed this Jan 8, 2021
@mabelzhang mabelzhang deleted the mabelzhang/windows_install branch January 8, 2021 01:11
@mabelzhang mabelzhang mentioned this pull request Jan 8, 2021
Closed
@mabelzhang
Copy link
Contributor Author

I replaced the branch so I can't reopen this PR... Opening a 3rd.

@mabelzhang mabelzhang mentioned this pull request Jan 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JShep1 JShep1 JShep1 left review comments

@chapulina chapulina Awaiting requested review from chapulina

@caguero caguero Awaiting requested review from caguero caguero is a code owner

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel documentation Improvements or additions to documentation 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice Windows Windows support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mabelzhang @JShep1 @chapulina @nkoenig @scpeters @caguero @mjcarroll @j-rivero @tykurtz @Pro