Support optional dataset downloading from Hugging Face with caching #15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the AMP loader by adding support for downloading datasets from Hugging Face using the login in https://github.com/ami-iit/amp-rsl-rl/blob/main/example/load_amp_dataset.py. The changes primarily focus on extending the
AMPLoaderclass and its integration, along with minor updates to dependencies.Enhancements to AMP functionality:
amp_rsl_rl/runners/amp_on_policy_runner.py: Updated the initialization ofAMPLoaderto include new parameters such asdownload_from_hf,robot_folder, andrepo_id, enabling dataset downloads from Hugging Face.amp_rsl_rl/utils/motion_loader.py: Modified theAMPLoaderclass to support optional parameters for downloading datasets from Hugging Face, including handling cache directories and repository details. Added a fallback to create a cache directory usingplatformdirsifdataset_path_rootis not provided.Dependency updates:
pyproject.toml: Addedplatformdirs>=4.0.0to dependencies for managing cache directories required by the new Hugging Face dataset download functionality.Minor improvements:
amp_rsl_rl/utils/motion_loader.py: AddedOptionalto type hints for better clarity and flexibility in function signatures.