-
Notifications
You must be signed in to change notification settings - Fork 16
Issue 5793: Remove pre-populated instance properties in deployment script #6040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
77 commits
Select commit
Hold shift + click to select a range
96cf7d3
5793: Create CDKDefinedVariants of properties
rtjd6554 8e6c763
5793: Application of Accout and Region
rtjd6554 3be913d
5793: Remove Account from CommonProperty and repoint imports
rtjd6554 52fb097
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 de6e28c
5793: Update missing account reference
rtjd6554 3c4a135
5793: Adjust common property Region
rtjd6554 e8aab6d
5793: Update documentation
rtjd6554 2df4545
5793: Test updates for property changes
rtjd6554 f1896ce
5793: Update to SleeperPropertiesValidationTest
rtjd6554 144b671
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 a47612a
5793: Update mandatory details for Account and Region
rtjd6554 52fb4db
5793: Remove properties not UserDefined
rtjd6554 aae952b
5793: Update change for ID tag property
rtjd6554 838ef0d
5793: Update to remove populate for production code
rtjd6554 cff7089
5793: Add missing configuration file
rtjd6554 262238c
5793: Refactor DeployInstanceConfigurationIT
rtjd6554 f7ea82d
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 27983ba
5793: Correct class usage
rtjd6554 d48d53e
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 56bf9f4
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 319baad
5793: Remove remaining populate usage in DeployInstance
rtjd6554 e24ab9b
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 ac65c53
5793: Update property definitions
rtjd6554 30dfc5c
5793: Update to replace populate within tests
rtjd6554 d909491
5793: Update more testhelper usages
rtjd6554 d1c8285
5793: Delete test class
rtjd6554 1aba20c
5793: Refactor location of setting of test instance properties
rtjd6554 b599681
5793: Break unintentional loop
rtjd6554 e8294d9
5793: Fix method signature
rtjd6554 c8e1fa1
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 9c59978
5793: Update method signature
rtjd6554 d08a5b4
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 8b2c371
5793: Correctt static method usage
rtjd6554 e4b91e7
5793: Refactor remaining populate usages out of testing
rtjd6554 81b92bb
5793: Refactor out the populateInstaceProperties class and last remai…
rtjd6554 0bba933
5793: Typo fix
rtjd6554 405d36a
5793: Refactor location of loadTags
rtjd6554 475ed84
5793: Update local variable definition
rtjd6554 435c227
5793: Update wording
rtjd6554 2ddd95b
5793: Remove properties not required
rtjd6554 0b995c0
5793: Update templates definiton
rtjd6554 159bc0c
5793: Update for a common property usage
rtjd6554 9c332cf
5793: Update property.txt
rtjd6554 364690a
5793: Update region and account setting
rtjd6554 56497c5
5793: Removal of unused Region from SyncJarsRequest
rtjd6554 029b5ae
5793: Update wording
rtjd6554 b334c60
5793: Refactor TablePropertiesTestHelper to within relevant tests
rtjd6554 8887d57
5793: Update for a different CommonProperty
rtjd6554 87e6d9b
5793: Update for determination of Account and Region
rtjd6554 d4905df
5793: Simply InstanePropertiesTestHelper
rtjd6554 9b40887
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 1e909b0
5793: Temp change to pass tests
rtjd6554 542b4b4
5793: Update UploadDockerImagesToEcr to use Account and Region
rtjd6554 1d8685f
5793: Update admin Client
rtjd6554 c4d7c3f
5793: Refactor for StsClients
rtjd6554 f14148e
5793: Remove TODO's
rtjd6554 65cf608
5793: Correct missing method usage
rtjd6554 12ff099
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 ec77e82
5793: Update missing tags validation
rtjd6554 cf71cdc
5793: Update javadoc
rtjd6554 ebdc298
5793: Update Region and Account descriptions
rtjd6554 19f0098
5793: Update SystemTestApp
rtjd6554 e9845e5
5793: Remove redundant TODO
rtjd6554 ef1393e
5793: Rename method arguments
rtjd6554 6924829
5793: Update argument verification
rtjd6554 aea3b69
5793: Update captilisation on JavaDoc
rtjd6554 eee31b7
5793: New test for tagProperties
rtjd6554 331eecd
5793: Include value as part of validation
rtjd6554 73ea104
5793: Change RegionProvider to field over local variable
rtjd6554 70b2867
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 facdef1
5793: Update approval for default-instance
rtjd6554 2427c5f
5793: Fix for spot bugs issue
rtjd6554 7280d21
Merge branch 'develop' into 5793-Remove-prepopulate-properties
rtjd6554 9c99c37
5793: System test adjust for spot bugs
rtjd6554 fed550f
5793: Remove invalid modifier
rtjd6554 cd297bd
5793: Update from review comments
rtjd6554 77ef963
5793: Update logic surrounding unit tests
rtjd6554 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.