fix: QName constructor calls #191
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #190. A dependency updated which changed the default behaviour of a constructor call. This fixes it so that it calls the constructor correctly (which it's already doing in the same file.)
Where should the reviewer @DANS-KNAW/easy start?
I'd recommend checking that your systems don't break with the change, though I consider this unlikely. If you prefer, we could talk about automated testing...
How should this be manually tested?
Test this in DSpace by submitting a package to DSpace using the sword endpoint. See the original issue. I've been able to test this and verify that the changes work my institution's instance of DSpace.