Skip to content

fix: QName constructor calls #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: QName constructor calls #191

wants to merge 1 commit into from

Conversation

mrwerdo
Copy link

@mrwerdo mrwerdo commented Jun 17, 2025

This fixes issue #190. A dependency updated which changed the default behaviour of a constructor call. This fixes it so that it calls the constructor correctly (which it's already doing in the same file.)

Where should the reviewer @DANS-KNAW/easy start?

I'd recommend checking that your systems don't break with the change, though I consider this unlikely. If you prefer, we could talk about automated testing...

How should this be manually tested?

Test this in DSpace by submitting a package to DSpace using the sword endpoint. See the original issue. I've been able to test this and verify that the changes work my institution's instance of DSpace.

@pdurbin pdurbin moved this to Ready for Triage in IQSS Dataverse Project Jun 17, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to SPRINT READY in IQSS Dataverse Project Jun 17, 2025
@ofahimIQSS ofahimIQSS moved this from SPRINT READY to Ready for Triage in IQSS Dataverse Project Jun 17, 2025
@ofahimIQSS ofahimIQSS moved this from Ready for Triage to Ready for Review ⏩ in IQSS Dataverse Project Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant