Shorten Firebase Dynamic Links #719
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| package org.gdg.frisbee.android.api; | ||
|
|
||
| import org.gdg.frisbee.android.api.model.FirebaseDynamicLinksResponse; | ||
|
|
||
| import okhttp3.RequestBody; | ||
| import retrofit2.Call; | ||
| import retrofit2.http.Body; | ||
| import retrofit2.http.Field; | ||
| import retrofit2.http.FormUrlEncoded; | ||
| import retrofit2.http.POST; | ||
| import retrofit2.http.Query; | ||
|
|
||
| /** | ||
| * Created by unstablebrainiac on 26/5/17. | ||
|
There was a problem hiding this comment. Please remove the comment. 😄 thanks |
||
| */ | ||
|
|
||
| public interface FirebaseDynamicLinksHub { | ||
|
There was a problem hiding this comment. What about just |
||
|
|
||
| @FormUrlEncoded | ||
| @POST("/v1/shortLinks") | ||
| Call<FirebaseDynamicLinksResponse> getShortenedUrl(@Query("key") String api_key, @Body RequestBody body); | ||
|
There was a problem hiding this comment. Just naming: Can you rename Also what about |
||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| package org.gdg.frisbee.android.api; | ||
|
|
||
| import com.google.gson.FieldNamingPolicy; | ||
|
|
||
| import org.gdg.frisbee.android.utils.Utils; | ||
|
|
||
| import okhttp3.OkHttpClient; | ||
| import retrofit2.Retrofit; | ||
| import retrofit2.converter.gson.GsonConverterFactory; | ||
|
|
||
| /** | ||
| * Created by unstablebrainiac on 26/5/17. | ||
| */ | ||
|
|
||
| public final class FirebaseDynamicLinksHubFactory { | ||
|
There was a problem hiding this comment.
|
||
| private static final String BASE_URL = "https://firebasedynamiclinks.googleapis.com"; | ||
|
|
||
| private FirebaseDynamicLinksHubFactory() { | ||
| } | ||
|
|
||
| private static Retrofit provideRestAdapter(OkHttpClient okHttpClient) { | ||
| return new Retrofit.Builder() | ||
| .baseUrl(BASE_URL) | ||
| .client(okHttpClient) | ||
| .addConverterFactory( | ||
| GsonConverterFactory.create(Utils.getGson(FieldNamingPolicy.LOWER_CASE_WITH_UNDERSCORES)) | ||
| ) | ||
| .build(); | ||
| } | ||
|
|
||
| public static FirebaseDynamicLinksHub provideFirebaseDynamicLinksApi(OkHttpClient okHttpClient) { | ||
| return provideRestAdapter(okHttpClient).create(FirebaseDynamicLinksHub.class); | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| package org.gdg.frisbee.android.api.model; | ||
|
|
||
| /** | ||
| * Created by unstablebrainiac on 26/5/17. | ||
| */ | ||
|
|
||
| public class FirebaseDynamicLinksResponse { | ||
| private String shortLink; | ||
|
There was a problem hiding this comment. Please mark the fields |
||
| private String previewLink; | ||
|
|
||
| public FirebaseDynamicLinksResponse(String shortLink, String previewLink) { | ||
| this.shortLink = shortLink; | ||
| this.previewLink = previewLink; | ||
| } | ||
|
|
||
| public String getShortLink() { | ||
| return shortLink; | ||
| } | ||
|
|
||
| public void setShortLink(String shortLink) { | ||
| this.shortLink = shortLink; | ||
| } | ||
|
|
||
| public String getPreviewLink() { | ||
| return previewLink; | ||
| } | ||
|
|
||
| public void setPreviewLink(String previewLink) { | ||
| this.previewLink = previewLink; | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,19 @@ | ||
| package org.gdg.frisbee.android.onboarding; | ||
|
|
||
| import android.app.ProgressDialog; | ||
| import android.support.v4.app.ShareCompat; | ||
|
|
||
| import org.gdg.frisbee.android.BuildConfig; | ||
| import org.gdg.frisbee.android.R; | ||
| import org.gdg.frisbee.android.api.Callback; | ||
| import org.gdg.frisbee.android.api.FirebaseDynamicLinksHub; | ||
| import org.gdg.frisbee.android.api.model.FirebaseDynamicLinksResponse; | ||
| import org.gdg.frisbee.android.app.App; | ||
| import org.gdg.frisbee.android.common.GdgActivity; | ||
| import org.gdg.frisbee.android.utils.PlusUtils; | ||
|
|
||
| import okhttp3.HttpUrl; | ||
| import okhttp3.RequestBody; | ||
|
|
||
| public class AppInviteLinkGenerator { | ||
|
|
||
|
|
@@ -16,31 +22,40 @@ public class AppInviteLinkGenerator { | |
|
|
||
| private final String dynamicLinkDomain; | ||
| private final String deepLinkBaseUrl; | ||
| private GdgActivity activity; | ||
| private ProgressDialog shareProgressDialog; | ||
|
|
||
| static String extractSender(HttpUrl httpUrl) { | ||
| return httpUrl.queryParameter(SENDER); | ||
| } | ||
|
|
||
| public static AppInviteLinkGenerator create(GdgActivity activity) { | ||
| return new AppInviteLinkGenerator("https://fmec6.app.goo.gl/", "https://gdg.events/", activity); | ||
| } | ||
|
|
||
| private AppInviteLinkGenerator(String dynamicLinkDomain, String deepLinkBaseUrl, GdgActivity activity) { | ||
| this.dynamicLinkDomain = dynamicLinkDomain; | ||
| this.deepLinkBaseUrl = deepLinkBaseUrl; | ||
| this.activity = activity; | ||
| } | ||
|
|
||
| public static void shareAppInviteLink(GdgActivity activity) { | ||
| AppInviteLinkGenerator linkGenerator = create(activity); | ||
| String gplusId = PlusUtils.getCurrentPlusId(activity); | ||
| HttpUrl appInviteLink; | ||
| if (gplusId != null) { | ||
| appInviteLink = linkGenerator.createAppInviteLink(gplusId); | ||
| linkGenerator.shareShortAppInviteLink(appInviteLink.toString()); | ||
| linkGenerator.shareProgressDialog = new ProgressDialog(activity); | ||
| linkGenerator.shareProgressDialog.setIndeterminate(true); | ||
| linkGenerator.shareProgressDialog.setCancelable(true); | ||
| linkGenerator.shareProgressDialog.setMessage(activity.getString(R.string.generating_url)); | ||
| linkGenerator.shareProgressDialog.show(); | ||
| } else { | ||
| appInviteLink = NON_SIGNED_IN_INVITE_URL; | ||
| linkGenerator.createChooser(appInviteLink); | ||
| } | ||
|
|
||
|
|
||
| activity.sendAnalyticsEvent("AppInvite", "Shared", | ||
| gplusId != null ? "Signed In" : "Non Signed In"); | ||
|
|
@@ -63,4 +78,30 @@ private String createDeepLink(String gplusId) { | |
| .toString(); | ||
| } | ||
|
|
||
| private void shareShortAppInviteLink(String longUrl) { | ||
| FirebaseDynamicLinksHub firebaseDynamicLinksHub = App.from(activity).getFirebaseDynamicLinksHub(); | ||
| String requestString = "{\"longDynamicLink\": \"" + longUrl + "\",\"suffix\": {\"option\": \"SHORT\"}}"; | ||
|
There was a problem hiding this comment. Just like the response, can you create a |
||
| RequestBody body = RequestBody.create(okhttp3.MediaType.parse("application/json; charset=utf-8"), requestString); | ||
| firebaseDynamicLinksHub.getShortenedUrl(BuildConfig.FIREBASE_WEB_API_KEY, body).enqueue(new Callback<FirebaseDynamicLinksResponse>() { | ||
| @Override | ||
| public void onSuccess(FirebaseDynamicLinksResponse response) { | ||
| createChooser(HttpUrl.parse(response.getShortLink())); | ||
| shareProgressDialog.dismiss(); | ||
|
There was a problem hiding this comment. Let's try to decouple the UI concerns and the actual link shortening. Now the link creation is asynchronous. Ideally we should have a Listener with a possible method Then the place where we implement this Listener can handle progress show/dismiss. What do you think? There was a problem hiding this comment. Resolved all the other errors but did not understand this very well. Isn't the Retrofit callback the method that you're talking about? Do you want me to create a separate method and call it from within Also, is there anything similar in the codebase that'll probably give me a better idea? There was a problem hiding this comment. Unfortunately not. The app doesn't follow any architecture and async handling codes are really old. We didn't have the chance to refactor yet. Would you be up to pair on this? We can connect via ScreenHero and do it together. There was a problem hiding this comment. Sure thing. But Screenhero is not accepting new signups right now so you'll have to send me an invite. My email ID is [email protected] and I am UnstableBrainiac on Slack. There was a problem hiding this comment. Hey! Sorry for the delayed response. I've been trying to get Screenhero to work on my system but couldn't. I even re-installed Windows to get it working, but in vain. I can still contribute though. Let me know what you need me to do. There was a problem hiding this comment. I didn't have time to check the latest version of the PR. Sorry. There was a problem hiding this comment. I will review once more and get back to you. |
||
| } | ||
|
|
||
| @Override | ||
| public void onError() { | ||
| createChooser(NON_SIGNED_IN_INVITE_URL); | ||
| shareProgressDialog.dismiss(); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| private void createChooser(HttpUrl appInviteLink) { | ||
| ShareCompat.IntentBuilder.from(activity) | ||
| .setChooserTitle(R.string.invite_friends) | ||
| .setText(activity.getString(R.string.invitation_message, appInviteLink)) | ||
| .setType("text/plain") | ||
| .startChooser(); | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure that you need a new api key? I think
IP_SIMPLE_API_ACCESS_KEYwould work. If you don't have that key, simple create one in Google api console. If you're not sure, feel free to ask us at https://gitter.im/gdg-x/frisbeeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this way may not right. hard to say