fix scenario.WithDefaults() #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaypipes
force-pushed
the
scenario-set-defaults
branch
2 times, most recently
from
c158b41 to
0b4ab8c
Compare
Adds a new `api.DefaultsHandler` interface that plugins must now implement. This `api.DefaultsHandler` inherits from `yaml.Unmarshaler` and exposes another `Merge()` method that accepts a map of variable override defaults received from `scenario.WithDefaults()` and merges those values with whatever the plugin returns from its `Defaults()` method. Issue #68 Signed-off-by: Jay Pipes <[email protected]>
jaypipes
force-pushed
the
scenario-set-defaults
branch
from
0b4ab8c to
ecc3374
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
api.DefaultsHandlerinterface that plugins must now implement. Thisapi.DefaultsHandlerinherits fromyaml.Unmarshalerand exposes anotherMerge()method that accepts a map of variable override defaults received fromscenario.WithDefaults()and merges those values with whatever the plugin returns from itsDefaults()method.Issue #68