Skip to content

feat: sails binary protocol program macro impl #1140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
techraed wants to merge 13 commits into
base: master-idl-v2
Choose a base branch
from
Draft

feat: sails binary protocol program macro impl #1140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
dd01f80
Initial implementation for alternative interface hashing
techraed Nov 19, 2025
c61de53
implement derive for the ReflectHash trait
techraed Nov 20, 2025
2b0ebd6
rebase
techraed Nov 21, 2025
c85f3fd
remove redundant
techraed Nov 24, 2025
9352fd1
fix after review calc for interface id
techraed Nov 24, 2025
94721ac
apply review results
techraed Dec 3, 2025
ccb1b97
implement header for idlv2/sails-binary protocol
techraed Dec 3, 2025
73e428c
add header impl
techraed Dec 3, 2025
cc69b8c
add tests, apply ai-review results
techraed Dec 8, 2025
2985359
adjsut check for reserved byte
techraed Dec 8, 2025
18beeaf
apply review results
techraed Dec 8, 2025
8387069
remove header builder
techraed Dec 8, 2025
fefc0bb
implement draft sails binary protocol
techraed Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions rs/ethexe/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_allow_attrs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl sails_rs::meta::ServiceMeta for SomeService {
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -193,7 +193,16 @@ impl sails_rs::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_basics.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ impl sails_rs::meta::ServiceMeta for SomeService {
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -190,7 +190,16 @@ impl sails_rs::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_crate_path.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ impl sails_rename::meta::ServiceMeta for SomeService {
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rename::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rename::meta::InterfaceId = {
let mut final_hash = sails_rename::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rename::keccak_const::Keccak256::new();
Expand Down Expand Up @@ -192,7 +192,16 @@ impl sails_rename::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rename::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_docs.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl sails_rs::meta::ServiceMeta for SomeService {
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -193,7 +193,16 @@ impl sails_rs::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_events.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ impl sails_rs::meta::ServiceMeta for MyServiceWithEvents {
type EventsMeta = my_service_with_events_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = false;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -206,7 +206,16 @@ impl sails_rs::meta::ServiceMeta for MyServiceWithEvents {
final_hash = final_hash
.update(&<MyEvents as sails_rs::sails_reflect_hash::ReflectHash>::HASH);
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod my_service_with_events_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_export.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ impl sails_rs::meta::ServiceMeta for SomeService {
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand Down Expand Up @@ -207,7 +207,16 @@ impl sails_rs::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
17 changes: 13 additions & 4 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_extends.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ impl sails_rs::meta::ServiceMeta for SomeService {
];
const ASYNC: bool = <ExtendedService1 as sails_rs::meta::ServiceMeta>::ASYNC
|| <ExtendedService2 as sails_rs::meta::ServiceMeta>::ASYNC;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -224,11 +224,20 @@ impl sails_rs::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
final_hash = final_hash
.update(&<ExtendedService1 as sails_rs::meta::ServiceMeta>::INTERFACE_ID);
.update(&<ExtendedService1 as sails_rs::meta::ServiceMeta>::INTERFACE_ID.0);
final_hash = final_hash
.update(&<ExtendedService2 as sails_rs::meta::ServiceMeta>::INTERFACE_ID);
.update(&<ExtendedService2 as sails_rs::meta::ServiceMeta>::INTERFACE_ID.0);
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
15 changes: 12 additions & 3 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_extends_and_lifetimes.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ impl<'a> sails_rs::meta::ServiceMeta for ExtendedWithLifetime<'a> {
sails_rs::meta::AnyServiceMeta::new::<BaseWithLifetime>,
];
const ASYNC: bool = <BaseWithLifetime as sails_rs::meta::ServiceMeta>::ASYNC;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -242,9 +242,18 @@ impl<'a> sails_rs::meta::ServiceMeta for ExtendedWithLifetime<'a> {
final_hash = final_hash.update(&fn_hash.finalize());
}
final_hash = final_hash
.update(&<BaseWithLifetime as sails_rs::meta::ServiceMeta>::INTERFACE_ID);
.update(&<BaseWithLifetime as sails_rs::meta::ServiceMeta>::INTERFACE_ID.0);
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod extended_with_lifetime_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_lifetimes_and_events.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ where
type EventsMeta = my_generic_events_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = false;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -163,7 +163,16 @@ where
final_hash = final_hash
.update(&<MyEvents as sails_rs::sails_reflect_hash::ReflectHash>::HASH);
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod my_generic_events_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_lifetimes_and_generics.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ where
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = false;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -148,7 +148,16 @@ where
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_methods_with_lifetimes.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ impl sails_rs::meta::ServiceMeta for ReferenceService {
type EventsMeta = reference_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand Down Expand Up @@ -377,7 +377,16 @@ impl sails_rs::meta::ServiceMeta for ReferenceService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod reference_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions rs/ethexe/macros-tests/tests/snapshots/service_insta__works_with_reply_with_value.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ impl sails_rs::meta::ServiceMeta for SomeService {
type EventsMeta = some_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = true;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -193,7 +193,16 @@ impl sails_rs::meta::ServiceMeta for SomeService {
final_hash = final_hash.update(&fn_hash.finalize());
}
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod some_service_meta {
Expand Down
13 changes: 11 additions & 2 deletions .../macros-tests/tests/snapshots/service_insta__works_with_special_lifetimes_and_events.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ where
type EventsMeta = my_generic_events_service_meta::EventsMeta;
const BASE_SERVICES: &'static [sails_rs::meta::AnyServiceMetaFn] = &[];
const ASYNC: bool = false;
const INTERFACE_ID: [u8; 8] = {
const INTERFACE_ID: sails_rs::meta::InterfaceId = {
let mut final_hash = sails_rs::keccak_const::Keccak256::new();
{
let mut fn_hash = sails_rs::keccak_const::Keccak256::new();
Expand All @@ -163,7 +163,16 @@ where
final_hash = final_hash
.update(&<MyEvents as sails_rs::sails_reflect_hash::ReflectHash>::HASH);
let hash = final_hash.finalize();
[hash[0], hash[1], hash[2], hash[3], hash[4], hash[5], hash[6], hash[7]]
sails_rs::meta::InterfaceId([
hash[0],
hash[1],
hash[2],
hash[3],
hash[4],
hash[5],
hash[6],
hash[7],
])
};
}
mod my_generic_events_service_meta {
Expand Down
Loading
Loading