refactor: simplify client traits

[m62624]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @m62624, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the client-side traits and associated code generation within the sails_rs framework. The changes aim to enhance code clarity, consistency, and maintainability by standardizing naming conventions for route identifiers, simplifying I/O macro usage, and consolidating client-related traits. These improvements lead to a more robust and easier-to-understand client API, particularly in how services and events are defined and handled.

Highlights

• Naming Convention Standardization: All _ROUTE_ID constants have been renamed to follow a ROUTE_ID_ prefix for improved consistency across the codebase.
• Simplified I/O Macro Usage: The sails_rs::io_struct_impl! macro no longer requires the explicit sails_rs::meta::InterfaceId::zero() argument, simplifying its invocation.
• Enhanced Event Identification: A new entry_id() method has been added to event enums, providing a more direct way to retrieve the event's identifier.
• Client Trait Refactoring: The CallCodec trait has been removed, and its essential functionality merged into the ServiceCall trait, streamlining client-side API definitions. The encode_params method was also removed from PendingCtor and ServiceCall.
• Improved Reply Decoding: The decode_reply method in the ServiceCall trait now includes a check for the interface_id in the message header, enhancing validation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant and valuable refactoring of the client-side traits and code generation. The simplification of ServiceCall by merging CallCodec, the improved naming convention for route ID constants, and the introduction of the entry_id() method on event enums all contribute to a cleaner and more robust client API. The changes are applied consistently across the codebase, including generated code and tests.

My review includes one suggestion to further improve the API clarity and safety of the ServiceCall trait by unifying the reply decoding methods.