feat(home): crypto listings screen with logos, MMKV cache and component conventions#5
Merged
Conversation
Co-authored-by: edug <gedu@users.noreply.github.com>
…d file Co-authored-by: edug <gedu@users.noreply.github.com>
…iew.tsx Co-authored-by: edug <gedu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1
Summary
FlatList, BTC hero section, and per-coin logo imagesThemedText/ThemedViewwith project-ownedText/Viewprimitives20.15.0, adds iOSbundleIdentifier+ Androidpackage, and addsreact-native-nitro-modulesas peer dep for MMKV v4Changes
app/(tabs)/index.tsxFlatListcoin list, BTC hero, API key validationcomponents/CoinRow,CoinLogo,HeroSection— top-level components, props-drivenhooks/useCoinLogos.tsstorage/createMMKV,remove)components/text.tsxThemedText(deleted)components/view.tsxThemedView(deleted)app.jsonbundleIdentifier(iOS) andpackage(Android)package.jsonexpo run:*, addedreact-native-nitro-modules.nvmrc20.15.0.claude/skills/react-native/SKILL.mdConventions documented in this PR
Three new rules added to the React Native skill — all applied in the code above:
keyExtractor/getItemLayoutdefined at module scope, not inside the componentheight: '25%'resolves to0insideFlatList/ScrollView; useuseWindowDimensionsinsteadTest plan
expo run:ios— home screen loads, coins render with logos