Skip to content

chore: Centralize all DEBUG checks in debugLog #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

max-stytch
Copy link
Contributor

Tiny QoL change - debugLog already checks the DEBUG global for us. There's no need to check it before invoking debugLog.

Copy link

pkg-pr-new bot commented Jun 17, 2025

Open in StackBlitz

npx https://pkg.pr.new/mcp-remote@108

commit: d829b50

@geelen
Copy link
Owner

geelen commented Jul 4, 2025

Ugh I was sure I'd already fixed this... twice now. Can you fix conflicts, then I'll merge

@max-stytch max-stytch force-pushed the max/chore-remove-debug-checks branch from 71c18bd to d829b50 Compare July 8, 2025 22:59
@max-stytch
Copy link
Contributor Author

@geelen Should be good now. I had to add back in a stub test to make vitest happy - https://github.com/geelen/mcp-remote/actions/runs/16156064484/job/45598668504

Figured a stub test would be better than ripping out tests entirely, though there are currently no tests in this package. I am not sure why other jobs haven't failed previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants