Make nodejs_generate_etc_profile an actual bool #171
Conversation
|
As a work around, you can add an [defaults]
ALLOW_BROKEN_CONDITIONALS=True |
|
It would be wonderfull if this can be merged soon so we can make a use of this role again |
…odejs 🐛 This allows running the playbook with Ansible >= 2.19. related: geerlingguy/ansible-role-nodejs#171
…odejs 🐛 This allows running the playbook with Ansible >= 2.19. related: geerlingguy/ansible-role-nodejs#171
…odejs 🐛 This allows running the playbook with Ansible >= 2.19. related: geerlingguy/ansible-role-nodejs#171
tasks/main.yml
Outdated
| NPM_CONFIG_PREFIX: "{{ npm_config_prefix }}" | ||
| NODE_PATH: "{{ npm_config_prefix }}/lib/node_modules" | ||
| NPM_CONFIG_UNSAFE_PERM: "{{ npm_config_unsafe_perm }}" | ||
| NPM_CONFIG_UNSAFE_PERM: "{{ npm_config_unsafe_perm | bool }}" |
There was a problem hiding this comment.
This appears to do the opposite of what should be done? This is coercing what is now (by default) a bool to a bool. Presumably you want to coerce a bool to a string instead?
There was a problem hiding this comment.
Coercing to string would cause the exact same issue we're trying to avoid here
There was a problem hiding this comment.
This line isn't a conditional. It's an environment variable.
tasks/main.yml
Outdated
| npm: | ||
| path: "{{ nodejs_package_json_path }}" | ||
| when: nodejs_package_json_path is defined and nodejs_package_json_path | ||
| when: nodejs_package_json_path is defined and nodejs_package_json_path | bool |
There was a problem hiding this comment.
This should already be a bool too, I think?
There was a problem hiding this comment.
It might be but doesn't have to, that's why we're coercing it
There was a problem hiding this comment.
I added parentheses to make the intention here clearer
There was a problem hiding this comment.
Ohhh I totally misread this line, apologies. Seems like it would be better/clearer to check explicitly for an empty string? But, 🤷
4 participants
Ansible 2.19 requires values used in conditionals to be actual bools and not just values that can be coerced to a bool