Consolidate dependency updates from Dependabot PRs#120
Conversation
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25.0 and performs a dependency cleanup in cicd-mcp-server, removing unused packages and updating others like protobuf and jsonparser. Feedback indicates that the Go version update is likely premature as Go 1.25 is not yet a stable release, and it is recommended to move the cicd/lib/bm25 dependency to the main requirement block to follow standard Go conventions.
alex-doudou
force-pushed
the
chore/consolidated-deps
branch
2 times, most recently
from
6e938fd to
6bbd469
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Go version from 1.24.8 to 1.25.0 and refreshes several Go module dependencies, including google.golang.org/protobuf, github.com/segmentio/encoding, golang.org/x/mod, golang.org/x/oauth2, golang.org/x/sync, and github.com/buger/jsonparser. It also removes various unused indirect dependencies and introduces cicd/lib/bm25 as a new direct dependency. The review suggests improving the go.mod file's readability by relocating the cicd/lib/bm25 dependency to the primary direct dependency block.
There was a problem hiding this comment.
Code Review
This pull request updates project-wide dependencies and bumps the Go version to 1.25.0 in the cicd-mcp-server module. The updates include major libraries such as gRPC, protobuf, and go-git, while removing several unused cloud and telemetry packages. Feedback was provided to improve the organization of the local-kb-index-builder/go.mod file by grouping the direct dependency cicd/lib/bm25 with other direct dependencies to maintain consistency with the rest of the project.
alex-doudou
force-pushed
the
chore/consolidated-deps
branch
from
6bbd469 to
63fbee5
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25.5 for the cicd-mcp-server module and performs extensive dependency updates across the project, including the addition of the bm25 library to multiple modules. Feedback indicates that the Go version should be updated consistently across all modules in the monorepo to avoid potential tooling issues.
alex-doudou
force-pushed
the
chore/consolidated-deps
branch
from
63fbee5 to
9b69c98
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request upgrades the Go version to 1.25.5 across the repository's modules and updates several core dependencies, including the Model Context Protocol SDK, gRPC, and Protobuf. Feedback focuses on maintaining dependency version consistency across the monorepo, specifically noting mismatches for jsonparser, filepath-securejoin, and several golang.org/x packages between the cicd-mcp-server, testclient, and local-kb-index-builder modules.
alex-doudou
force-pushed
the
chore/consolidated-deps
branch
from
9b69c98 to
6c0d7ed
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request upgrades the Go version to 1.25.5 across multiple modules and updates various dependencies, including gRPC, Protobuf, and the MCP SDK. Feedback was provided regarding a redundant indirect dependency entry for github.com/philippgille/chromem-go in the cicd-mcp-server/go.mod file, which is already listed as a direct dependency.
alex-doudou
force-pushed
the
chore/consolidated-deps
branch
from
6c0d7ed to
fa4831d
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Go version to 1.25.5 across the project and upgrades several core dependencies, including the MCP Go SDK, gRPC, and Protobuf. It also adds a local library dependency, cicd/lib/bm25, to the server and index builder modules. A high-severity concern was raised regarding the removal of the cloud.google.com/go/storage dependency in the server module, as this could lead to build failures if the package is still in use.
|
/gcbrun |
|
/gcbrun(fa4831d) |
Consolidates updates from #109, #112, #114, #118, #119. - Unified Go version to 1.25.5 and aligned shared dependencies across monorepo. - Intentional Removal: cloud.google.com/go/storage is removed as GCS operations now use gcloud CLI. - Resolved structural inconsistencies and duplicate entries (chromem-go, blocks). - Verified build and unit tests pass across all modules.
alex-doudou
force-pushed
the
chore/consolidated-deps
branch
from
fa4831d to
81b79d2
Compare
|
/gcbrun(81b79d2) |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the Go toolchain version from 1.24 to 1.25 across the repository, including the Cloud Build configuration and multiple go.mod files. It also bumps several dependencies, such as the Model Context Protocol Go SDK and gRPC. Feedback was provided suggesting a revert of the Go version in the go.mod file to the stable 1.24.8 release, as 1.25 is not yet available.
2 participants
This PR consolidates the following dependency updates into a single manual PR: