-
Notifications
You must be signed in to change notification settings - Fork 5
Always create new release, pre-release returns sha to avoid race conditions #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
638fbff
Improvements to Rag and design prompt, remove knowledge queries
ef7cc3c
Result refactor
513993f
Fix imports
3595fb6
Add logging to seperate file
a467ac8
Fix log name
e0c8c19
Always create new release, pre-release returns sha to avoid race cond…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,60 +1,45 @@ | ||
| # Copyright 2025 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name: Prepare Release | ||
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: | ||
| release: | ||
| required: true | ||
| type: string | ||
| default: dev | ||
| workflow_dispatch: # Allows manual triggering of the workflow | ||
|
|
||
| env: | ||
| RELEASE: dev | ||
| GH_TOKEN: ${{ github.token }} | ||
| workflow_call: | ||
| inputs: | ||
| release: | ||
| required: true | ||
| type: string | ||
| default: dev | ||
| outputs: | ||
| release_sha: | ||
| description: "The SHA that was tagged" | ||
| value: ${{ jobs.prep-release.outputs.sha }} | ||
|
|
||
| jobs: | ||
| prep-release: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 | ||
|
|
||
| - name: Prepare for a new release | ||
| id: prep | ||
| run: | | ||
| export RELEASE="${{ env.RELEASE }}" | ||
| if [[ "${{ inputs.release }}" != "" ]]; then | ||
| echo "Updating to RELEASE to ${{ inputs.release }}" | ||
| RELEASE="${{ inputs.release }}" | ||
| fi | ||
| echo "RELEASE=${RELEASE}" >> "$GITHUB_OUTPUT" | ||
|
|
||
| echo "Preparing for \"${RELEASE}\" release" | ||
| git config --local user.email "[email protected]" | ||
| git config --local user.name "GitHub Action" | ||
| git tag -fa -m "${RELEASE} release" "${RELEASE}" | ||
| #git push --force origin "${RELEASE}" | ||
| echo "Release tag created \"${RELEASE}\"" | ||
|
|
||
| # check of a release already exists | ||
| if [[ $(gh release view "${RELEASE}") ]]; then | ||
| echo "Release already exists!" | ||
| else | ||
| echo "Creating new release ${RELEASE}" | ||
| gh release create --prerelease ${RELEASE} | ||
| fi | ||
| prep-release: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| # ADD THIS SECTION | ||
| outputs: | ||
| sha: ${{ steps.get_sha.outputs.sha }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: main | ||
|
|
||
| # ADD THIS STEP | ||
| - name: Get Commit SHA | ||
| id: get_sha | ||
| run: echo "sha=$(git rev-parse HEAD)" >> $GITHUB_OUTPUT | ||
|
|
||
| - name: Update Rolling Release | ||
| env: | ||
| RELEASE_TAG: ${{ inputs.release || env.RELEASE }} | ||
| run: | | ||
| # ... (Same deletion logic as before) ... | ||
|
|
||
| # ... (Same creation logic) ... | ||
| gh release create "$RELEASE_TAG" \ | ||
| --prerelease \ | ||
| --target "${{ steps.get_sha.outputs.sha }}" \ | ||
| --title "$RELEASE_TAG build" \ | ||
| --generate-notes | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add license headers