Skip to content

Conversation

@0xh3rman
Copy link
Collaborator

No description provided.

@semanticdiff-com
Copy link

semanticdiff-com bot commented Nov 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  packages/swapper/src/mayan/evm.ts  99% smaller
  pnpm-lock.yaml  50% smaller
  packages/swapper/package.json  5% smaller
  justfile Unsupported file format
  packages/swapper/src/orca/provider.ts  0% smaller
  scripts/provider-bench.ts  0% smaller

@gemini-code-assist
Copy link

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly updates the project's dependencies, focusing on the Orca and Mayan swap SDKs, as well as several core Solana libraries. These updates necessitated specific code modifications within the Mayan and Orca provider implementations to ensure compatibility with the new API versions. A notable addition is a new benchmarking script, accessible via a justfile command, designed to measure and evaluate the performance of different swap providers.

Highlights

  • Dependency Upgrades: Major version updates for Orca and Mayan swap SDKs, along with several Solana-related packages, have been applied to ensure the project uses the latest stable versions of these critical libraries.
  • API Adaptations: Code adjustments were made in both the Mayan and Orca provider implementations to maintain compatibility with breaking changes introduced by the updated dependencies. This includes refactoring buildEvmQuoteData to be asynchronous and updating Solana instruction types.
  • Benchmarking Tool: A new provider-bench.ts script and a corresponding justfile command have been introduced. This tool allows for benchmarking the performance of various swap providers, aiding in performance monitoring and optimization.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several key dependencies, including @mayanfinance/swap-sdk, @orca-so/whirlpools, and @solana/kit, to their latest major versions. The code changes primarily adapt to the new APIs and type definitions from these updated packages. A new benchmarking script has also been added to facilitate performance testing of different swap providers. The changes look good and are necessary for keeping the project up-to-date. I have one suggestion to improve the maintainability of the new benchmark script.

@0xh3rman 0xh3rman merged commit 5f74840 into main Nov 24, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants