-
Notifications
You must be signed in to change notification settings - Fork 2
Bump Orca / Stonfi deps #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bump @orca-so/whirlpools and @orca-so/whirlpools-client to 6.0.0, @ston-fi/api to 0.29.0, and @ton/ton to 15.4.0 in swapper package. Also update related Solana program dependencies to latest versions in pnpm-lock.yaml for compatibility and improvements.
Changed Files
|
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on updating critical dependencies for Orca and Stonfi within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates several dependencies, including major version bumps for @orca-so/whirlpools (v5 to v6) and various @solana/* packages. While new integration tests have been added for the Stonfi provider, which is excellent, there are no corresponding tests for the Orca provider. Major version updates often introduce breaking changes, and merging this without verifying the Orca integration is risky and could break functionality in production. This is a critical issue. I strongly recommend adding integration tests for the Orca provider to ensure it works correctly with the new dependencies before this PR is merged.
I've also left a couple of comments on the new test files with suggestions for improving code clarity and maintainability.
Separates from_asset and to_asset from other overrides to ensure nested properties are merged correctly, improving the flexibility and reliability of testkit quote request creation.
Introduced a version.json file to provide version and commit information in the API root endpoint. Updated the build process to generate this file before building, adjusted .gitignore and tsconfig.json to handle the new file.
The script was previously ignored by *.js in .gitignore. Updated .gitignore to allow scripts/*.js files. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
No description provided.