Add Bitcoin WalletConnect support #849

DRadmir · 2025-12-18T17:00:50Z

Add BIP122 namespace for Bitcoin chain identification
Add sendTransfer and signMessage methods to WalletConnectionMethods
Create gem_bitcoin signer module with BIP137 message signing
Add BitcoinRequestHandler for WalletConnect request parsing
Add BitcoinPersonal sign type and Bitcoin transaction type

semanticdiff-com · 2025-12-18T17:00:53Z

Review changes with

Changed Files

File	Status
gemstone/src/wallet_connect/mod.rs	78% smaller
gemstone/src/wallet_connect/response_handler.rs	5% smaller
crates/primitives/src/wallet_connect_namespace.rs	2% smaller
gemstone/src/message/signer.rs	1% smaller
Cargo.lock	Unsupported file format
crates/gem_bitcoin/Cargo.toml	Unsupported file format
crates/gem_bitcoin/src/lib.rs	0% smaller
crates/gem_bitcoin/src/signer/encoding.rs	0% smaller
crates/gem_bitcoin/src/signer/mod.rs	0% smaller
crates/gem_bitcoin/src/signer/signature.rs	0% smaller
crates/gem_bitcoin/src/signer/types.rs	0% smaller
crates/primitives/src/wallet_connect.rs	0% smaller
crates/primitives/src/wallet_connector.rs	0% smaller
gemstone/Cargo.toml	Unsupported file format
gemstone/src/config/wallet_connect.rs	0% smaller
gemstone/src/message/sign_type.rs	0% smaller
gemstone/src/wallet_connect/actions.rs	0% smaller
gemstone/src/wallet_connect/request_handler/bitcoin.rs	0% smaller
gemstone/src/wallet_connect/request_handler/mod.rs	0% smaller

gemini-code-assist · 2025-12-18T17:01:16Z

Summary of Changes

Hello @DRadmir, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands WalletConnect capabilities by adding full support for Bitcoin. It establishes the necessary infrastructure to allow users to securely sign messages and send transactions on the Bitcoin network through WalletConnect, enhancing interoperability and user experience for Bitcoin holders.

Highlights

Bitcoin WalletConnect Namespace: Introduced the BIP122 namespace for Bitcoin chain identification within WalletConnect, allowing proper recognition and handling of Bitcoin chains.
Bitcoin WalletConnect Methods: Added sendTransfer and signMessage methods to the WalletConnectionMethods enum, enabling WalletConnect to initiate Bitcoin transfers and message signing.
Bitcoin Signer Module: Created a dedicated gem_bitcoin signer module that implements BIP137 message signing, providing the core cryptographic functionality for Bitcoin message authentication.
Bitcoin Request Handler: Implemented a BitcoinRequestHandler to parse and process WalletConnect requests specifically for Bitcoin, routing signMessage and sendTransfer calls appropriately.
Bitcoin Sign and Transaction Types: Added BitcoinPersonal to the SignDigestType enum and a Bitcoin variant to WalletConnectTransactionType, integrating Bitcoin-specific operations into the general message and transaction handling framework.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces comprehensive Bitcoin support for WalletConnect, enabling personal message signing and transfer functionality. Key changes include adding hex, serde_json, sha2, and signer dependencies, and integrating a new gem_bitcoin signer module with a signer feature. The gem_bitcoin crate now includes sign_personal for BIP137-compliant signatures and defines BitcoinSignMessageData and BitcoinSignDataResponse for message handling. WalletConnect primitives were updated to recognize Bitcoin via Bip122 CAIP2, and new BtcSendTransfer and BtcSignMessage methods were added. The gemstone crate was configured to support Bitcoin in WalletConnect, including a new BitcoinPersonal sign digest type and a dedicated BitcoinRequestHandler for parsing WalletConnect requests. Review comments highlighted the need to improve error handling in BitcoinSignMessageData::to_bytes by returning a Result instead of using unwrap_or_default(), making the address parameter mandatory in parse_sign_message, and updating corresponding call sites and test cases to reflect these error propagation changes.

gemini-code-assist · 2025-12-18T17:04:12Z

crates/gem_bitcoin/src/signer/types.rs

+    pub fn to_bytes(&self) -> Vec<u8> {
+        serde_json::to_vec(self).unwrap_or_default()
+    }


The to_bytes method uses unwrap_or_default(), which can hide serialization errors by returning an empty vector. This can lead to obscure bugs in downstream code that consumes this output. It's better to propagate the error by returning a Result, which also makes the method's signature symmetric with from_bytes.

Suggested change

pub fn to_bytes(&self) -> Vec<u8> {

serde_json::to_vec(self).unwrap_or_default()

}

pub fn to_bytes(&self) -> Result<Vec<u8>, SignerError> {

serde_json::to_vec(self).map_err(SignerError::from)

}

gemstone/src/wallet_connect/request_handler/bitcoin.rs

gemini-code-assist · 2025-12-18T17:04:13Z

crates/gem_bitcoin/src/signer/signature.rs

+    #[test]
+    fn test_sign_bitcoin_personal() {
+        let btc_data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string());
+        let data = btc_data.to_bytes();


Following the recommended change of to_bytes to return a Result, this call site needs to be updated. Using .unwrap() is acceptable here as this is a test case.

Suggested change

let data = btc_data.to_bytes();

let data = btc_data.to_bytes().unwrap();

gemini-code-assist · 2025-12-18T17:04:13Z

crates/gem_bitcoin/src/signer/signature.rs

+    #[test]
+    fn test_sign_bitcoin_personal_rejects_invalid_key() {
+        let btc_data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string());
+        let data = btc_data.to_bytes();


Following the recommended change of to_bytes to return a Result, this call site needs to be updated. Using .unwrap() is acceptable here as this is a test case.

Suggested change

let data = btc_data.to_bytes();

let data = btc_data.to_bytes().unwrap();

gemini-code-assist · 2025-12-18T17:04:13Z

gemstone/src/message/signer.rs

+            SignDigestType::BitcoinPersonal => {
+                let message = BitcoinSignMessageData::from_bytes(&self.message.data).unwrap_or_default();
+                message.message
+            }


Using unwrap_or_default() here can hide deserialization errors from from_bytes. If an error occurs, an empty string will be returned for the preview without any indication of what went wrong. It's better to handle the Result explicitly to avoid providing a misleading or empty preview.

Suggested change

SignDigestType::BitcoinPersonal => {

let message = BitcoinSignMessageData::from_bytes(&self.message.data).unwrap_or_default();

message.message

}

SignDigestType::BitcoinPersonal => {

BitcoinSignMessageData::from_bytes(&self.message.data)

.map(|m| m.message)

.unwrap_or_default()

}

gemini-code-assist · 2025-12-18T17:04:13Z

gemstone/src/wallet_connect/request_handler/bitcoin.rs

+            .unwrap_or_default();
+
+        let btc_data = BitcoinSignMessageData::new(message.to_string(), address.to_string());
+        let data = String::from_utf8(btc_data.to_bytes()).map_err(|e| format!("Failed to encode BitcoinSignMessageData: {}", e))?;


To accommodate the recommended change of to_bytes returning a Result, this line needs to be updated to handle the potential serialization error before converting the bytes to a UTF-8 string.

Suggested change

let data = String::from_utf8(btc_data.to_bytes()).map_err(|e| format!("Failed to encode BitcoinSignMessageData: {}", e))?;

let data = String::from_utf8(btc_data.to_bytes().map_err(|e| e.to_string())?).map_err(|e| e.to_string())?;

- Add BIP122 namespace for Bitcoin chain identification - Add sendTransfer and signMessage methods to WalletConnectionMethods - Create gem_bitcoin signer module with BIP137 message signing - Add BitcoinRequestHandler for WalletConnect request parsing - Add BitcoinPersonal sign type and Bitcoin transaction type

gemcoder21

@0xh3rman can you review and run a small audit?

gemcoder21 · 2025-12-18T19:33:44Z

gemstone/src/message/signer.rs

                Ok(self.get_result(&signed))
            }
+            SignDigestType::BitcoinPersonal => {
+                let response = bitcoin_sign_personal(&self.message.data, &private_key)?;


do one liner

gemcoder21 · 2025-12-18T19:33:52Z

gemstone/src/message/signer.rs

                Ok(decoded)
            }
+            SignDigestType::BitcoinPersonal => {
+                let message = BitcoinSignMessageData::from_bytes(&self.message.data)?;


do one liner

gemcoder21 · 2025-12-18T19:34:22Z

gemstone/src/wallet_connect/request_handler/bitcoin.rs

+    }
+
+    fn parse_send_transaction(chain: Chain, params: Value) -> Result<WalletConnectAction, String> {
+        params


can you add model to decode recipientAddress and amount ? easier to read then

gemcoder21 · 2025-12-18T19:35:23Z

gemstone/Cargo.toml

 bs58 = { workspace = true }
 url = { workspace = true }
 zeroize = "1.8"
+sha2 = { workspace = true }


can we keep sha2 it out of gemstone?

gemcoder21 · 2025-12-18T19:36:07Z

gemstone/src/message/signer.rs

                _ => "".to_string(),
            },
+            SignDigestType::BitcoinPersonal => {
+                let message = BitcoinSignMessageData::from_bytes(&self.message.data).unwrap_or_default();


unwrap_or_default no unwrap here, throw an error if not able to decode

gemcoder21 · 2025-12-18T19:38:00Z

crates/gem_bitcoin/src/signer/types.rs

+    fn test_response_to_json() {
+        let response = BitcoinSignDataResponse::new("bc1qtest".to_string(), "27abcdef".to_string());
+
+        let json = response.to_json().unwrap();


gemcoder21 · 2025-12-18T19:38:22Z

crates/gem_bitcoin/src/signer/types.rs

+        let data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string());
+        let hash = data.hash();
+
+        assert_eq!(hash.len(), 32);


no need to check for hash.len() if you check for hex

gemcoder21 · 2025-12-18T19:38:45Z

crates/gem_bitcoin/src/signer/signature.rs

+        let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").expect("valid hex");
+
+        let response = sign_personal(&data, &private_key).expect("signing succeeds");
+        let json = response.to_json().unwrap();


gemcoder21 · 2025-12-18T19:38:57Z

crates/gem_bitcoin/src/signer/signature.rs

+        let btc_data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string());
+        let data = btc_data.to_bytes();
+
+        let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").expect("valid hex");


Suggested change

let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").expect("valid hex");

let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").unwrap();

gemcoder21 · 2025-12-18T19:39:34Z

crates/gem_bitcoin/src/signer/signature.rs

+
+    #[test]
+    fn test_sign_bitcoin_personal() {
+        let btc_data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string());


just do let let data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string()).to_bytes()

0xh3rman · 2025-12-19T01:15:58Z

crates/gem_bitcoin/src/signer/types.rs

+    }
+}
+
+fn encode_varint(n: usize) -> Vec<u8> {


this method can be moved to an encoding.rs can be reused later

0xh3rman · 2025-12-19T02:46:18Z

gemstone/src/wallet_connect/request_handler/bitcoin.rs

+            .and_then(|v| v.as_str())
+            .unwrap_or_default();
+
+        let btc_data = BitcoinSignMessageData::new(message.to_string(), address.to_string());


looks like we can use serde to decode and encode data？ Value js serde_json::Value and String::from_utf8(btc_data.to_bytes()) can be simplified

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gemcoder21 · 2025-12-22T19:50:37Z

crates/gem_bitcoin/src/signer/encoding.rs

+    use super::*;
+
+    #[test]
+    fn test_encode_varint_small() {


merge into one test_encode_varint

gemcoder21 · 2025-12-22T19:51:15Z

crates/gem_bitcoin/src/signer/signature.rs

+    fn test_sign_bitcoin_personal() {
+        let data = BitcoinSignMessageData::new("Hello Bitcoin".to_string(), "bc1qtest".to_string()).to_bytes();
+        let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").unwrap();
+        let parsed: serde_json::Value = serde_json::from_str(&sign_personal(&data, &private_key).unwrap().to_json().unwrap()).unwrap();


let data = sign_personal(&data, &private_key).unwrap()

gemini-code-assist bot reviewed Dec 18, 2025

View reviewed changes

DRadmir force-pushed the bitcoin-walletconnect branch from 960fa92 to cfb1a4a Compare December 18, 2025 17:35

gemcoder21 requested a review from 0xh3rman December 18, 2025 19:33

gemcoder21 reviewed Dec 18, 2025

View reviewed changes

0xh3rman reviewed Dec 19, 2025

View reviewed changes

DRadmir and others added 2 commits December 19, 2025 11:00

PR code review

7de29f6

Apply suggestions from code review

cdbe84e

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

gemcoder21 reviewed Dec 22, 2025

View reviewed changes

gemcoder21 approved these changes Dec 22, 2025

View reviewed changes

DRadmir merged commit 9a8a739 into main Dec 22, 2025
6 checks passed

DRadmir deleted the bitcoin-walletconnect branch December 22, 2025 20:46

	let data = btc_data.to_bytes();
	let data = btc_data.to_bytes().unwrap();

	let data = String::from_utf8(btc_data.to_bytes()).map_err(\|e\| format!("Failed to encode BitcoinSignMessageData: {}", e))?;
	let data = String::from_utf8(btc_data.to_bytes().map_err(\|e\| e.to_string())?).map_err(\|e\| e.to_string())?;

	let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").expect("valid hex");
	let private_key = hex::decode("1e9d38b5274152a78dff1a86fa464ceadc1f4238ca2c17060c3c507349424a34").unwrap();

Add Bitcoin WalletConnect support #849

Add Bitcoin WalletConnect support #849

Uh oh!

Conversation

DRadmir commented Dec 18, 2025

Uh oh!

semanticdiff-com bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 18, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist bot Dec 18, 2025

Choose a reason for hiding this comment

Uh oh!

gemcoder21 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

semanticdiff-com bot commented Dec 18, 2025 •

edited

Loading