Simplify QuoteResponse by using serde_json::Value

[0xh3rman]

• Replaces the strongly-typed PlatformFee and Route/RouteSwapInfo structs in QuoteResponse with serde_json::Value.
• This change allows for more flexible deserialization of platform_fee and route_plan fields, accommodating dynamic or variable response structures.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/swapper/src/jupiter/model.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request simplifies the QuoteResponse data structure by replacing specific, strongly-typed structs with serde_json::Value for the platform_fee and route_plan fields. The primary goal is to enhance the flexibility and robustness of the deserialization process, allowing the system to gracefully handle dynamic or evolving data schemas from the Jupiter API without requiring frequent code updates to match exact structures.

Highlights

• Data Structure Simplification: Replaced strongly-typed PlatformFee, Route, and RouteSwapInfo structs within QuoteResponse with serde_json::Value.
• Enhanced Flexibility: This modification enables more flexible deserialization for the platform_fee and route_plan fields, better accommodating dynamic or variable response structures from external APIs.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the QuoteResponse struct by replacing the strongly-typed PlatformFee and Route structs with serde_json::Value. This change increases flexibility and resilience to changes in the Jupiter API for the platform_fee and route_plan fields.

While this is a valid approach for handling potentially dynamic API responses, it comes at the cost of compile-time type safety and makes the code less self-documenting. My review includes suggestions to add comments to document the expected JSON structure for these fields, which will improve the code's maintainability without sacrificing the desired flexibility.