Add builder and agent approval logic for spot swaps

[0xh3rman]

Fixes #862

• Enhanced spot swap handling in HyperCore by introducing builder and agent approval logic.
• Updated preload to check for spot swaps and fetch necessary approvals and credentials.
• Modified signer to process multiple transactions for agent, builder, and referral approvals, and to use the agent's private key for signing the order.
• Updated swapper provider to include builder information in market orders.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
crates/swapper/src/hyperliquid/provider/spot/provider.rs	67% smaller
crates/gem_hypercore/src/signer/core_signer.rs	28% smaller
crates/gem_hypercore/src/provider/preload.rs	1% smaller
crates/swapper/src/config.rs	0% smaller

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly upgrades HyperCore's spot swap functionality by integrating a robust approval system for builders and agents. It ensures that all required approvals and credentials are dynamically fetched during the preload phase, and that the signing process can handle a sequence of approval transactions before executing the main swap order, ultimately including builder information in the market order.

Highlights

• Spot Swap Approval Logic: Introduced builder and agent approval logic for spot swaps within HyperCore to enhance transaction security and flexibility.
• Preload Updates: Enhanced the preload mechanism to identify spot swaps and dynamically retrieve necessary agent, referral, and builder approvals and credentials.
• Signer Modifications: Updated the core signer to process multiple approval transactions (for agent, builder, and referral) and to use the agent's private key for signing the final order.
• Swapper Provider Integration: Modified the swapper provider to incorporate builder details, including address and fee, into market orders for spot swaps.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds builder and agent approval logic for spot swaps. The changes look good overall, introducing necessary logic in the preload, signer, and swapper components.

My review includes a few suggestions to improve maintainability and reduce code duplication. Specifically, I've pointed out a duplicated BUILDER_ADDRESS constant and a hardcoded BUILDER_FEE_BPS which should probably be made configurable. I've also suggested refactoring some duplicated logic for handling approval transactions into a helper function, and simplifying control flow in the preload logic. Finally, there's a minor optimization to remove an unnecessary clone.