Skip to content

Conversation

@0xh3rman
Copy link
Collaborator

@0xh3rman 0xh3rman commented Jan 5, 2026

Bumps reqwest to 0.13.1 and tokio to 1.49.0, and switches Sentry to rustls to remove native-tls from the graph.

Benefits of rustls:

  • Consistent TLS across platforms with fewer system/SDK dependencies
  • Smaller native surface area (no platform SSL frameworks)
  • Easier cross-platform builds and CI

@semanticdiff-com
Copy link

semanticdiff-com bot commented Jan 5, 2026

Review changes with  SemanticDiff

Changed Files
File Status
  .cargo/audit.toml Unsupported file format
  .github/workflows/ci.yml  0% smaller
  Cargo.lock Unsupported file format
  Cargo.toml Unsupported file format
  crates/tracing/Cargo.toml Unsupported file format

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant upgrade of core asynchronous networking and runtime components by bumping reqwest and tokio to their latest versions. The primary architectural change involves migrating the TLS backend from native-tls to rustls. This strategic shift is intended to improve cross-platform consistency, reduce the native attack surface, and streamline the build process by removing platform-specific SSL frameworks. The update also includes a cleanup of the dependency graph, removing outdated TLS-related crates and introducing new ones that align with the rustls ecosystem.

Highlights

  • Dependency Updates: The reqwest crate has been updated to version 0.13.1 and the tokio runtime crate has been updated to 1.49.0.
  • TLS Backend Migration: The project's TLS implementation has been transitioned from native-tls to rustls, aiming for enhanced security, simplified cross-platform builds, and reduced system dependencies.
  • Dependency Graph Cleanup: Several native-tls and openssl related dependencies, including foreign-types, hyper-tls, and tokio-native-tls, have been removed from the Cargo.lock file.
  • New Dependencies for Rustls: New dependencies such as cesu8, jni, jni-sys, and rustls-platform-verifier have been introduced to support the rustls integration.
  • Reqwest Feature Addition: The query feature has been explicitly added to the reqwest dependency in the main Cargo.toml.
  • Sentry Configuration Update: The sentry dependency in crates/tracing/Cargo.toml has been reconfigured to disable default features and explicitly enable rustls along with other necessary features.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates reqwest and tokio dependencies and successfully removes native-tls from the dependency graph by configuring sentry to use rustls. The changes in Cargo.toml and crates/tracing/Cargo.toml are mostly correct and achieve the stated goal. However, there is a critical issue with the specified sentry version in crates/tracing/Cargo.toml which appears to be incorrect and would likely cause build failures. I've left a comment with a suggestion to fix it. Otherwise, the dependency updates look good.

@0xh3rman 0xh3rman merged commit 9763f54 into main Jan 5, 2026
4 checks passed
@0xh3rman 0xh3rman deleted the chore/deps-refresh branch January 5, 2026 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants