-
Notifications
You must be signed in to change notification settings - Fork 53
Add reproducible build verification #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust mechanism to ensure the reproducibility of the Android application's builds. By providing a script and documentation, it empowers users to independently verify that the publicly distributed APKs are byte-for-byte identical to those built from the source code, thereby enhancing transparency and trust in the release process. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a robust mechanism for reproducible build verification, which is a great addition for transparency and security. The new verify_apk.sh script is well-structured, using Docker to create a consistent build environment and then comparing the locally built APK with the official one. The documentation in README.md is clear and provides good examples. I have one suggestion to improve the clarity of a command-line option in the script.
Enhances GitHub Actions workflows and Dockerfiles for better build caching and performance. Adds cache steps for NDK and AVD in CI, switches to setup-just action, and optimizes Docker buildx usage and cache sharing in docker.yml. Updates Dockerfile.base and Dockerfile.app to use Dockerfile 1.4 syntax, cache mounts for dependencies, and more efficient SDK installation. justfile updated to enable BuildKit for Docker builds.
Summary
This PR adds reproducible build verification infrastructure to enable independent auditors and researchers to verify that published APKs match the source code. It implements Gradle dependency verification, a Docker-based verification script, and optimized tooling for maintaining verification metadata.
Key Changes
🔐 Gradle Dependency Verification
dependencyLocking.lockAllConfigurations()for all projectsgradle/verification-metadata.xmlwith SHA-256 checksums for all dependencies🐳 Reproducible Build Verification
scripts/verify_apk.sh- a Docker-based script to rebuild and verify APKs⚡ Optimized Verification Metadata Generation
just generate-verification-metadatatask that:local.properties📚 Documentation
🛠️ Code Quality
verify_apk.shwith main function for better readabilityVerification Example
Benefits
Testing