Skip to content

Conversation

@0xh3rman
Copy link
Contributor

@0xh3rman 0xh3rman commented Nov 14, 2025

  1. Add helper script to add dependencies
  2. Disable it for now (Android Studio complains too much)

Introduces scripts/add_verification_dependency.sh and scripts/generate_verification_metadata.sh to automate Gradle dependency verification metadata management. Updates the justfile to use these scripts for generating and adding verification metadata. Removes the obsolete scripts/extract_aab_apk.sh. Updates verification-metadata.xml to reflect dependency changes.
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the project's dependency verification workflow by introducing a more robust and automated system for managing gradle/verification-metadata.xml. The changes streamline the process of adding and updating dependency hashes, particularly for Gradle distributions and key development tools like KSP, thereby improving build security and maintainability. Additionally, it cleans up the codebase by removing an outdated utility script.

Highlights

  • Dependency Verification Automation: Introduced new scripts and justfile recipes to automate the process of adding dependencies to the Gradle verification metadata, making it easier to manage and update.
  • Gradle Distribution Hashes: The new automation now automatically includes Gradle distribution hashes in the verification metadata, ensuring that Gradle upgrades do not break dependency verification.
  • KSP and Kotlin Dependency Updates: Updated the gradle/verification-metadata.xml file to include the latest SHA256 hashes for various com.google.devtools.ksp components (version 2.2.21-2.0.4) and org.jetbrains.kotlin:kotlin-stdlib (version 2.2.10).
  • Script Removal: An obsolete script, scripts/extract_aab_apk.sh, which was used for extracting APKs from AAB files, has been removed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a robust mechanism for managing Gradle's dependency verification metadata, which is a great improvement for build stability and security. The new scripts to add individual dependencies and to automatically handle the Gradle distribution hashes are well-structured. I've identified a significant security vulnerability in how dependencies are passed to Gradle, and a minor robustness issue in how the Gradle version is parsed. Addressing these points will make the new scripts even more solid.

@0xh3rman 0xh3rman changed the title Add verification dependency Disable verification dependency Nov 14, 2025
@0xh3rman 0xh3rman merged commit 563013d into main Nov 14, 2025
2 checks passed
@0xh3rman 0xh3rman deleted the add-verification-dependency branch November 14, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants