Restore silent error handling in deleteKey for backward compatibility #1362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The original code silently ignored .invalidPrivateKey and .invalidPrivateKeyEncoding errors when deleting wallets. The async/await refactor changed this to throw these errors, which could cause wallet deletion to fail in cases where it previously succeeded. This reverts the error handling to maintain backward compatibility. Co-authored-by: gemcoder21 <[email protected]>
Copilot
AI
changed the title
[WIP] WIP address feedback on keystore and wallet operations
Restore silent error handling in deleteKey for backward compatibility
Nov 4, 2025
Contributor
|
@copilot I think we need to return an error here via resume |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The async/await refactor changed
deleteKeyto throw.invalidPrivateKeyand.invalidPrivateKeyEncodingerrors instead of silently ignoring them as the original implementation did.Changes
LocalKeystore.deleteKeyto ignore.invalidPrivateKeyand.invalidPrivateKeyEncodingerrorsThis preserves the original contract where
WalletService.delete(_:)completes successfully even in edge cases where private key operations fail during cleanup.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.