Add MobSF static analysis integration and config

[0xh3rman]

Introduces MobSF mobsfscan for static security analysis with a new GitHub Actions workflow, a .mobsf configuration file, and a justfile command for local usage. Updates the README with security scanning instructions and adds inline suppressions for specific MobSF rules. Also includes minor code cleanups and enum case renaming for consistency.

[gemini-code-assist]

Summary of Changes

Hello @0xh3rman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates MobSF static security analysis into the project's development lifecycle. It establishes a new CI workflow for automated scanning, provides local tooling for developers, and updates documentation, ensuring that security vulnerabilities are proactively identified and addressed.

Highlights

• MobSF Integration: Introduced MobSF mobsfscan for static security analysis to proactively identify vulnerabilities.
• CI/CD Workflow: Added a new GitHub Actions workflow (.github/workflows/mobsfscan.yml) to automatically run MobSF scans on pushes and pull requests to the main branch, failing the workflow if findings remain.
• Configuration: Included a .mobsf configuration file to define paths to ignore during scans and set severity filters for WARNING and ERROR level findings.
• Local Development Support: Provided a just mobsfscan command for developers to easily run MobSF scans locally, including a check for uv installation.
• Documentation Update: Updated the README.md with a new 'Security Scanning' section, detailing MobSF's purpose, local usage instructions, and CI enforcement.
• Code Adjustments: Applied inline suppressions for specific MobSF rules in relevant code sections and performed minor code cleanups, including enum case renaming for consistency.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/mobsfscan.yml

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request successfully integrates MobSF static analysis, a valuable addition for enhancing the project's security posture. The new configuration, justfile command, and documentation updates are well-implemented. The inline suppressions for MobSF rules appear justified, addressing likely false positives. I have one specific comment regarding a change to an enum's raw values, which could impact data persistence and should be reviewed to ensure backward compatibility.

[gemini-code-assist]

This change removes the explicit string raw values for the WalletImportType enum cases. This means the raw values will be implicitly generated from the case names (e.g., case .phrase will have a raw value of "phrase" instead of "Phrase").

While this improves code consistency, it's a breaking change if these raw values are persisted (e.g., in UserDefaults, Keychain, or sent to an API) or used for any other form of serialization. Please verify that these raw values are not used for persistence to avoid breaking backward compatibility or causing data inconsistencies for existing users.

[0xh3rman]

This should be fine, we're using localizable strings now