-
Notifications
You must be signed in to change notification settings - Fork 58
Add Stable chain and logo #1518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @0xh3rman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces comprehensive support for the new 'Stable' blockchain. It updates core chain enumerations, integrates its visual assets, and ensures proper compatibility with the WalletCore framework, allowing the application to recognize and interact with the 'Stable' chain. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for the 'Stable' chain, including its logo and necessary enum cases and mappings across different packages. The changes are generally well-implemented and follow the existing project structure.
However, there is a critical issue that needs to be addressed: the tests will likely fail because of the new chain. The test testChainToCoinType in Packages/WalletCore/Tests/WalletCorePrimitivesTests/Chain+WalletCorePrimitiveTests.swift iterates through all Chain.allCases but hasn't been updated to handle the new .stable case, which will cause a crash. Please update the tests to cover the new chain.
Additionally, for improved maintainability, I've left a suggestion to sort the list of EVM-compatible chains alphabetically. It would be beneficial to apply similar sorting to other large enum/switch blocks in the future.
No description provided.