Improved unit tests for Amount*ViewModel #1551
Conversation
Introduces comprehensive unit tests for AmountFreezeViewModel, AmountPerpetualViewModel, AmountStakeViewModel, and AmountTransferViewModel. Updates AmountSceneViewModelTests with improved and additional test cases. Adds a mock utility for PerpetualRecipientData and extends Balance mock to support withdrawable balances, enhancing test coverage and reliability for transfer-related view models.
Summary of ChangesHello @gemdev111, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly bolsters the testing infrastructure for the Transfer feature by introducing a suite of new, comprehensive unit tests for several Amount*ViewModel classes. The changes aim to improve the reliability and maintainability of these view models by ensuring their core logic, such as title generation, resource selection, value calculations, and transfer data creation, is thoroughly validated. This enhancement also includes updates to existing test files and the addition of new mock data capabilities to support these expanded test scenarios. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request significantly improves the test coverage for the amount-related view models by introducing comprehensive unit tests for AmountFreezeViewModel, AmountPerpetualViewModel, AmountStakeViewModel, and AmountTransferViewModel. The updates to AmountSceneViewModelTests are also great, with better organization and new test cases. The addition of mock utilities for PerpetualRecipientData and the extension of the Balance mock are valuable for enhancing test reliability.
Overall, this is a solid contribution to improving the robustness of our transfer feature. I have one minor suggestion to make one of the new tests even more complete. Great work!
| #expect(unstake.type.transactionType == .stakeUndelegate) | ||
| #expect(redelegate.type.transactionType == .stakeRedelegate) | ||
| #expect(withdraw.type.transactionType == .stakeWithdraw) | ||
| #expect(stake.value == 100) |
There was a problem hiding this comment.
This test is slightly incomplete. It creates unstake, redelegate, and withdraw transfer data but doesn't assert their value property. To make the test more robust and ensure the values are passed correctly for all actions, it would be good to add assertions for their values as well.
#expect(stake.value == 100)
#expect(unstake.value == 100)
#expect(redelegate.value == 100)
#expect(withdraw.value == 100)Added assertions to verify that unstake, redelegate, and withdraw transactions have the expected value of 100 in AmountStakeViewModelTests.
Introduces comprehensive unit tests for AmountFreezeViewModel, AmountPerpetualViewModel, AmountStakeViewModel, and AmountTransferViewModel. Updates AmountSceneViewModelTests with improved and additional test cases. Adds a mock utility for PerpetualRecipientData and extends Balance mock to support withdrawable balances, enhancing test coverage and reliability for transfer-related view models.