Skip to content

feat(claude): allow enabling skip-permissions toggle on running tasks #1685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Fizza-Mukhtar wants to merge 2 commits into
base: main
Choose a base branch
from
+53 −8
Open

feat(claude): allow enabling skip-permissions toggle on running tasks #1685

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
465d8f0
feat(claude): allow toggling auto-approve on running tasks
Fizza-Mukhtar Apr 7, 2026
125531a
race condition
Fizza-Mukhtar Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 53 additions & 8 deletions src/renderer/components/ChatInterface.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,9 +937,15 @@ const ChatInterface: React.FC<Props> = ({
// 2. The global "auto-approve by default" setting is on
// In both cases the provider must actually support an auto-approve flag.
const { settings: autoApproveSettings } = useAppSettings();
const [autoApproveOverride, setAutoApproveOverride] = useState<boolean | null>(null);
useEffect(() => {
setAutoApproveOverride(null);
}, [task.id]);
const autoApproveEnabled =
(Boolean(task.metadata?.autoApprove) ||
Boolean(autoApproveSettings?.tasks?.autoApproveByDefault)) &&
(autoApproveOverride !== null
? autoApproveOverride
: Boolean(task.metadata?.autoApprove) ||
Boolean(autoApproveSettings?.tasks?.autoApproveByDefault)) &&
Boolean(agentMeta[agent]?.autoApproveFlag);

const isMainConversation = activeConversationId === mainConversationId;
Expand Down Expand Up @@ -1202,14 +1208,53 @@ const ChatInterface: React.FC<Props> = ({
githubIssue={task.metadata?.githubIssue || null}
jiraIssue={task.metadata?.jiraIssue || null}
/>
{autoApproveEnabled && (
<span
className="inline-flex h-7 select-none items-center gap-1.5 rounded-md border border-border bg-muted px-2.5 text-xs font-medium text-foreground"
title="Auto-approve enabled"
{Boolean(agentMeta[agent]?.autoApproveFlag) && (
<button
type="button"
onClick={() => {
void (async () => {
const next = !autoApproveEnabled;
setAutoApproveOverride(next);
try {
await rpc.db.saveTask({
...task,
metadata: {
...task.metadata,
autoApprove: next,
},
});
if (next) {
// Kill the running PTY so the session manager restarts it
// with autoApprove: true on next spawn.
window.electronAPI.ptyKill(terminalId);
}
} catch (error) {
console.error('Failed to update auto-approve setting:', error);
setAutoApproveOverride(null);
toast({
title: 'Error',
description: 'Failed to update auto-approve setting.',
variant: 'destructive',
});
}
})();
}}
className={`inline-flex h-7 select-none items-center gap-1.5 rounded-md border px-2.5 text-xs font-medium transition-colors ${
autoApproveEnabled
? 'border-orange-500/40 bg-orange-500/10 text-orange-600 hover:bg-orange-500/20 dark:text-orange-400'
: 'border-border bg-muted text-muted-foreground hover:bg-accent hover:text-foreground'
}`}
title={
autoApproveEnabled
? 'Auto-approve enabled — click to disable'
: 'Enable auto-approve (skip permissions)'
}
>
<span className="h-1.5 w-1.5 rounded-full bg-orange-500" />
<span
className={`h-1.5 w-1.5 rounded-full ${autoApproveEnabled ? 'bg-orange-500' : 'bg-muted-foreground'}`}
/>
Auto-approve
</span>
</button>
)}
</div>
</div>
Expand Down