Improve observability components and documentation #1001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
iroqueta
commented
Aug 8, 2025
iroqueta
commented
- Add comprehensive README.md for gxobservability module with overview, features, and usage examples
- Enhance GXSpanContextTest with a more robust test for the default constructor:
- Create a controlled testing environment with SdkTracerProvider
- Set up a span with known trace and span IDs
- Make it the current span and verify that GXSpanContext captures it correctly
- Validate exact trace and span ID values instead of just structure
- Add unit tests for all core components:
- GXTraceContextTest
- OtelSpanTest
- OtelTracerTest
- Update implementation files with improved code documentation and error handling
- Enhance OpenTelemetryHelper with better exception handling and documentation
1. Add comprehensive README.md for gxobservability module with overview, features, and usage examples 2. Enhance GXSpanContextTest with a more robust test for the default constructor: - Create a controlled testing environment with SdkTracerProvider - Set up a span with known trace and span IDs - Make it the current span and verify that GXSpanContext captures it correctly - Validate exact trace and span ID values instead of just structure 3. Add unit tests for all core components: - GXTraceContextTest - OtelSpanTest - OtelTracerTest 4. Update implementation files with improved code documentation and error handling 5. Enhance OpenTelemetryHelper with better exception handling and documentation
Cherry pick to beta success |
1. Create ExtractAttributeValueHelper class to expose attribute extraction functionality with a clean public API for testing purposes 2. Implement comprehensive ExtractAttributeValueTest with test cases for: - Null parameters handling - Empty string handling - Simple key-value extraction - Multiple attribute extraction - Non-existent attribute handling 3. Update OtelTracerTest to include reflection-based testing approach
Cherry pick to beta success |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.