Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add [paginator-render] component #475

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add [paginator-render] component #475

wants to merge 3 commits into from

Conversation

jonatan-reto
Copy link
Collaborator

workerB

Changes we propose in this PR:

  • Add the ch-paginator-render component, which provides navigation for pages or data tables.
  • The component supports Shadow DOM and is built with accessibility in mind.
  • It supports UI models using either hyperlinks or buttons.

@jonatan-reto jonatan-reto added feature Feature implementation pull request target: minor This PR is targeted for the next minor release labels Jan 28, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 28, 2025 •
edited
Loading

✅ Deploy Preview for gx-chameleon ready!

Name Link
🔨 Latest commit 2a0b320
🔍 Latest deploy log https://app.netlify.com/sites/gx-chameleon/deploys/67aa119ecb296600073235bf
😎 Deploy Preview https://deploy-preview-475--gx-chameleon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

ncamera
ncamera requested changes Jan 30, 2025
View reviewed changes
Copy link
Collaborator

@ncamera ncamera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!!

src/showcase/assets/components/paginator-render/paginator-render.showcase.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
src/components/paginator-render/paginator-render.scss Show resolved Hide resolved
src/components/paginator-render/paginator-render.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncamera ncamera ncamera requested changes

@dangmarm dangmarm Awaiting requested review from dangmarm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
feature Feature implementation pull request target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonatan-reto @ncamera