[mercury] Add the viteMercury plugin for Vite environments
#646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us to avoid issues when the Mercury dependency is duplicated. Also, this help us to set this mapping inline in the HTML.
This plugin replaces the need for using the CLI in Vite environments.
Also, inline the base/base bundle by default and preload the base/icons bundle by default.
Also, fix default values for mercuryOptions
ncamera
added
feature
…li and vite-mercury-plugin packages Now, @genexus/mercury only contains the core of Mercury, and we have packages for bulding Mercury, using it through out a CLI, and a plugin to work with Vite. Breaking changes: - The default path for the fonts is now "/assets/fonts/" instead of "./assets/fonts/" - The default path for the icons is now "/assets/icons/" instead of "./assets/icons/"
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+50
to
+52
| fileDir: fileMetadata.dir | ||
| .replace(MERCURY_DIST_RELATIVE_FOLDERS.DIST_BUNDLES_SCSS, "") | ||
| .replace("\\", "/") |
Check failure
Code scanning / CodeQL
Incomplete string escaping or encoding High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 12 days ago
To ensure all backslashes in fileMetadata.dir are replaced with forward slashes, the best way is to use a regular expression with the global flag: .replace(/\\/g, "/"). This replaces all occurrences, not just the first. Because the only change required is to the single line inside the BUNDLES.push call, we only need to update this line in packages/mercury-build/src/build/internal/transpile-bundle-and-create-mappings.ts. No additional imports or definitions are needed, since this is standard JavaScript regex usage.
Suggested changeset
1
packages/mercury-build/src/build/internal/transpile-bundle-and-create-mappings.ts
| @@ -60,7 +60,7 @@ | ||
| BUNDLES.push({ | ||
| fileDir: fileMetadata.dir | ||
| .replace(MERCURY_DIST_RELATIVE_FOLDERS.DIST_BUNDLES_SCSS, "") | ||
| .replace("\\", "/") | ||
| .replace(/\\/g, "/") | ||
| }); | ||
|
|
||
| const transpiledBundle = transpileBundle( |
Copilot is powered by AI and may make mistakes. Always verify output.
packages/mercury-build/src/build/internal/transpile-bundle-and-create-mappings.ts
Fixed
Show fixed
Hide fixed
We are no longer splitting the scss build with the assets copy, so we can centralize the Mercury build process
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This plugin replaces the need for using the CLI in Vite environments.