[GO] allow multiple types in jsonschema#1221
Conversation
|
We want to fix these tests here (currently skipped because they fail): https://github.com/firebase/genkit/blob/fe24a4e36fad88f1fb094748904e9bc40f7c2ff5/go/plugins/dotprompt/picoschema_test.go#L44 |
falonso81
changed the title
| google.golang.org/grpc v1.65.0 // indirect | ||
| ) | ||
|
|
||
| replace github.com/invopop/jsonschema => github.com/alonsopf/jsonschema v0.0.0-20241112034953-8a224be9076f |
There was a problem hiding this comment.
Revert? Or are you actually relying on changes in your fork?
There was a problem hiding this comment.
I actually relying on changes in my fork to support multiple types
There was a problem hiding this comment.
Ah, that's no good. We don't want to rely on a fork of this, it's not sustainable for us to maintain it. Is there any way to roll those changes into the Genkit library? Otherwise we need to explore a different solution.
There was a problem hiding this comment.
I opened a PR in the jsonschema repo, also I'm reviewing anothers options if doesn't get merged
There was a problem hiding this comment.
Unfortunately, I believe the maintainer of the package has stated that they do not intend to support multiple types because Go is strongly typed and this would make it very complicated. We need a different solution, either a different package or something creative within our own codebases.
There was a problem hiding this comment.
sounds good, I tried to do in this PR using our own codebase #1400
|
closing to use our own code in #1400 |
2 participants
adding support for multiple_types here: invopop/jsonschema@main...alonsopf:jsonschema:main
Checklist (if applicable):