fix(prompt): prompt metadata for middleware and tools#5216
Open
MichaelDoyle wants to merge 2 commits intomainfrom
Open
fix(prompt): prompt metadata for middleware and tools#5216MichaelDoyle wants to merge 2 commits intomainfrom
MichaelDoyle wants to merge 2 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances prompt metadata by capturing tool choice and middleware configurations during prompt definition and loading. It introduces a helper function to extract middleware names and configurations into a standardized format. Feedback suggests improving consistency in this helper by omitting the 'config' key when it is empty or null, matching the logic used for other input types.
MichaelDoyle
force-pushed
the
md/go/prompt-metadata
branch
3 times, most recently
from
d423770 to
5f8760e
Compare
MichaelDoyle
force-pushed
the
md/go/prompt-metadata
branch
from
5f8760e to
2192ece
Compare
MichaelDoyle
force-pushed
the
md/go/prompt-metadata
branch
from
57d1baa to
59d7f0e
Compare
apascal07
reviewed
May 1, 2026
| if variant != "" { | ||
| promptMetadata["variant"] = variant | ||
| } | ||
| promptMetadata["name"] = name |
Collaborator
There was a problem hiding this comment.
These mostly get overwritten with maps.Copy() in DefinePrompt, no? Only some survive because they're not set there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description here... Help the reviewer by:
Checklist (if applicable):