feat(tools): consolidate OTLP routes to prioritize standard v1 endpoints#5225
Open
MichaelDoyle wants to merge 1 commit intomainfrom
Open
feat(tools): consolidate OTLP routes to prioritize standard v1 endpoints#5225MichaelDoyle wants to merge 1 commit intomainfrom
MichaelDoyle wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request consolidates multiple OTLP endpoints into a single handler and refactors trace and log processing to use schema-based parsing and individual span broadcasting. Feedback was provided regarding the span broadcasting logic, noting that it should emit both start and end events and sort them chronologically to maintain consistency with other endpoints and avoid potential UI display issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to hook up gemini-cli (which has migrated to Otel) to our telemetry server and it immediately blew up due to allocation of "large" strings. The culprit was that the
/api/otlp/:parentTraceId/:parentSpanIdendpoint matched all of the standard Otlp endpoints by accident, creating one giant trace with the traceIdv1.Speaking with SamB, we don't actually need this endpoint.
Remove experimental
/api/otlp/:parentTraceId/:parentSpanIdendpoint, because:Support the standard OTel endpoints. We must add these, or we'll not be able to accept standard Otel traffic.
v1/tracesv1/logsv1/metricsFor now, the same route handles everything, just as before. But ideally, we'd want to break it out in the very near future.
Checklist (if applicable):
Screenshot
See also