Skip to content

feat(tools): consolidate OTLP routes to prioritize standard v1 endpoints#5225

Open
MichaelDoyle wants to merge 1 commit intomainfrom
md/otlp-endpoints
Open

feat(tools): consolidate OTLP routes to prioritize standard v1 endpoints#5225
MichaelDoyle wants to merge 1 commit intomainfrom
md/otlp-endpoints

Conversation

@MichaelDoyle
Copy link
Copy Markdown
Contributor

@MichaelDoyle MichaelDoyle commented May 1, 2026

I tried to hook up gemini-cli (which has migrated to Otel) to our telemetry server and it immediately blew up due to allocation of "large" strings. The culprit was that the /api/otlp/:parentTraceId/:parentSpanId endpoint matched all of the standard Otlp endpoints by accident, creating one giant trace with the traceId v1.

Speaking with SamB, we don't actually need this endpoint.

  • Remove experimental /api/otlp/:parentTraceId/:parentSpanId endpoint, because:

    • It conflicts with the standard OTel endpoints
    • It results in very very large traces that break
  • Support the standard OTel endpoints. We must add these, or we'll not be able to accept standard Otel traffic.

    • v1/traces
    • v1/logs
    • v1/metrics

For now, the same route handles everything, just as before. But ideally, we'd want to break it out in the very near future.

Checklist (if applicable):

Screenshot

image

See also

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates multiple OTLP endpoints into a single handler and refactors trace and log processing to use schema-based parsing and individual span broadcasting. Feedback was provided regarding the span broadcasting logic, noting that it should emit both start and end events and sort them chronologically to maintain consistency with other endpoints and avoid potential UI display issues.

Comment thread genkit-tools/telemetry-server/src/index.ts
@MichaelDoyle MichaelDoyle self-assigned this May 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant