Skip to content

Security: Private Keys Can Be Logged #1616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tomaioo wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −11
Open

Security: Private Keys Can Be Logged #1616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions backend/protocol_rpc/message_handler/types.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,6 @@ class EventScope(Enum):
TRANSACTION = "Transaction"


def show_validator_private_keys_in_logs() -> bool:
return os.getenv("SHOW_VALIDATOR_PRIVATE_KEYS_IN_LOGS", "").lower() in {
"1",
"true",
"yes",
}


def _is_private_key_field(key: Any) -> bool:
if not isinstance(key, str):
return False
Expand All @@ -37,9 +29,6 @@ def _is_private_key_field(key: Any) -> bool:

def sanitize_log_data(value: Any) -> Any:
"""Return a copy of log data with private-key fields removed."""
if show_validator_private_keys_in_logs():
return value

if isinstance(value, dict):
return {
key: sanitize_log_data(item)
Expand Down