Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced Gradio UI #89

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Enhanced Gradio UI #89

wants to merge 15 commits into from

Conversation

ParisNeo
Copy link

Enhanced Gradio interface UI
Added the possibility to select the host and port number when launching the gradio service
Added the possibility to select a specific GPU when launching the gradio service

demo.launch()
@click.option("--lora_path", required=False, help="Path to the lora file.")
@click.option("--cpu_offload", is_flag=True, help="Whether to offload model to CPU.")
@click.option("--gpu", default=None, help="Specify the GPU to use (e.g., 'cuda:0').")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the gpu option is used to set CUDA_VISIBLE_DEVICES, so the help text is incorrect (cuda:0 isn't valid). Could you remove the option? Users can set CUDA_VISIBLE_DEVICES manually.

@ParisNeo
Copy link
Author

ParisNeo commented Dec 1, 2024

You are right. I'll make the change. Thanks

@ParisNeo ParisNeo requested a review from paras-genmo December 2, 2024 07:51
@ParisNeo
Copy link
Author

Hi, can you please review my pull request?
Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants