targets/support/iso-bootloader-setup.sh: enable customization for gru… - #33
targets/support/iso-bootloader-setup.sh: enable customization for gru…#33StefanCristian wants to merge 1 commit into
Conversation
|
Thanks for doing! this very useful for downstreams. This missing the flags added here as acceptable options though in my first test: https://github.com/gentoo/catalyst/blob/master/catalyst/targets/livecd_stage2.py#L18 |
|
Tested with both Gentoo and work media to confirm this solves the downstream Thank you for tackling it <3 On the nitpicky side this needs to be squashed into one commit and requires a |
2eaa2db to
c6be7ac
Compare
|
Nearly perfect IMO. Just needs a highlight that it fixes the hardcoded values introduced in 6950b11 This way when a dev looks at this in 5 years time they can quickly understand the full picture of how this feature came to be and thought processes behind each decision. |
|
For Gentoo: Safe to merge once that last nit is added, and no spec changes are required as Gentoo needs are still the default settings. |
* introduced livecd/grub_theme spec option to select the GRUB theme path used in the generated ISO grub.cfg * introduced livecd/grub_timeout spec option for the GRUB menu timeout * kept previous behaviour when options are unset (gentoo_frosted theme and 10 second timeout), so existing specs build identically * registered both options in livecd_stage2.py valid_values, exported to iso-bootloader-setup.sh as clst_livecd_grub_theme and clst_livecd_grub_timeout by the existing environment * documented both options in catalyst-spec(5) * great thanks to @immolo for pointing out a lead trace where this could be fixed * this fixes the hardcoded GRUB theme and timeout values introduced in commit 6950b11 (GRUB theme support) by making them configurable through the spec file. Signed-off-by: Stefan Cristian B. <stefan.cristian+git@rogentos.ro>
c6be7ac to
aabb093
Compare
2 participants
…b theme
In order to use it, just add in your customized spec file something like:
livecd/grub_timeout: 30livecd/grub_theme: /boot/grub/themes/my_theme/theme.txtAlso changed into quotes, presumably shouldn't impact anything.