Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-1439: External IDs #72

Merged
merged 9 commits into from
Feb 20, 2025
Merged

PB-1439: External IDs #72

merged 9 commits into from
Feb 20, 2025

Conversation

msom
Copy link
Contributor

@msom msom commented Feb 18, 2025

CC @boecklic

This PR unifies the "external ID" (ID's which are used in the API and/or Cognito).

As per discussion in the ticket, the following changes have been made:

  • rename slug to <modelname>_id for Provider, Attribution, Dataset and PackageDistribution
  • add slug-like restrictions (a-z0-9_-.) to username`
  • add unique constraint to external ID for Dataset and PackageDistribution
  • use the external IDs in the API

No changes have been made for User: username is still used in API and user_id for Cognito.

The following table shows an overview of the final state:

Model External ID API Cognito
Provider provider_id provider_id as id
Attribution attribution_id attribution_id as id
Dataset dataset_id dataset_id as id
PackageDistribution package_distribution_id
User user_id username as username user_id

Checklist

@msom msom force-pushed the feat-PB-1439-external-id branch from ade0e03 to e351258 Compare February 18, 2025 08:31
@msom msom force-pushed the feat-PB-1439-external-id branch from d0a1091 to 6473ab5 Compare February 18, 2025 10:17
@msom msom requested a review from schtibe February 18, 2025 10:23
Copy link
Contributor

@schtibe schtibe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! 🚀

@msom msom merged commit cfab2fe into develop Feb 20, 2025
7 checks passed
@msom msom deleted the feat-PB-1439-external-id branch February 20, 2025 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants