PB-901: Modify name of KML file

[sommerfe]

Test link

[cypress]

web-mapviewer    Run #3641

Run Properties:   Passed #3641  •  c7850c97eb: PB-901: Modify name of KML file

Project	web-mapviewer
Branch Review	feat-pb-901-kml-change-name-file
Run status	Passed #3641
Run duration	04m 32s
Commit	c7850c97eb: PB-901: Modify name of KML file
Committer	Felix Sommer
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	21
Skipped	0
Passing	211
View all changes introduced in this branch ↗︎

[sommerfe]

Apparently i made a mistake during the rebase so most of my changes are gone, so i have to insert the right code

[pakb]

don't keep console.log when pushing code.
If you feel this log could help us later down the line, you can use the logging utils from src/utils/logging (there's a debug() or error() function that can be imported from this file)

[pakb]

From the user's perspective it doesn't really make sense that they can't start by filling the name of what they want to draw and then start drawing.

As you've already used a ref to store the name of the drawing (of the KML), I'd really want that we can edit this before the KML even exists. In the onSaveName, we could check that the KML exists before dispatching the change, and watch the activeKmlLayer for initial creation to set the name correctly.

I think this would really be better for user experience, I'm betting on multiple question/helpdesk interactions with question like "Why can't I change the drawing name"

[sommerfe]

When you change the name and then click on "Retour / Terminer Dessin" you are returned to the main menu but there is still the loading indication at the top so there might be an issue

[pakb]

Last part of the job (and not the easiest) : fix cypress testing 😉

[pakb]

Can you clean up a bit the git log? There's still my WIP commit message that should not be merged to develop as they are

You can squash stuff, and remove my commits, that's your work anyway