PB-1176: Minify the index.html #1165
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1176-minify
|
| Run status |
|
| Run duration | 05m 43s |
| Commit |
|
| Committer | Brice Schaffner |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
218
|
| View all changes introduced in this branch ↗︎ | |
|
This alone don't improve the situation because currently the index.html is big enough so that Cloudfront is compressing it and have a final size over network of 884 Bytes. If we minify it then it is too small to get compressed by Cloudfront and the final size over the network is 1.3K. |
ltshb
force-pushed
the
feat-PB-1176-minify
branch
3 times, most recently
from
a91824a to
65fc2fd
Compare
ltshb
force-pushed
the
feat-PB-1176-minify
branch
from
65fc2fd to
f130ec4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This remove the unnecessary white spaces
Test link