PB-1436 Switch to using pnpm instead of npm #1241
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schtibe
force-pushed
the
feat-pb-1436-pnpm
branch
13 times, most recently
from
5c4c768 to
639670e
Compare
schtibe
changed the title
schtibe
force-pushed
the
feat-pb-1436-pnpm
branch
2 times, most recently
from
6566499 to
a2e188f
Compare
schtibe
force-pushed
the
feat-pb-1436-pnpm
branch
2 times, most recently
from
ae4562e to
23650a7
Compare
pakb
approved these changes
Feb 14, 2025
schtibe
force-pushed
the
feat-pb-1436-pnpm
branch
6 times, most recently
from
e2a94ac to
f3ce942
Compare
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-pb-1436-pnpm
|
| Run status |
|
| Run duration | 05m 11s |
| Commit |
|
| Committer | Stefan Heinemann |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
22
|
Skipped
|
0
|
Passing
|
233
|
| View all changes introduced in this branch ↗︎ | |
schtibe
force-pushed
the
feat-pb-1436-pnpm
branch
from
82ca4e4 to
f8a0e6c
Compare
Adding a workspace configuration with a catalog to be used from all our packages. This will require to run `pnpm install` on the top level and it will install all required packages in our modularized packages. The catalog in the workspace configuration helps having the same version across all our sub-packages.
schtibe
force-pushed
the
feat-pb-1436-pnpm
branch
from
f8a0e6c to
aa1227d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PNPM
pnpm is a system that re-uses node_modules across multiple folders and projects. This results in way faster installs and less disk usage
Differences
The main difference is that one needs to run
pnpm installinstead ofnpm install,pnpm runinstead ofnpm runetc.Catalogs and Workspaces
The file
pnpm-workspaces.yamlis where this workspaces is defined. For one, it defines the packages that are included in this mono-repo. This helps with certain command and especially with cross-linking the packages.Secondly, there's a catalog definition. In there are the packages defined, that should be the same across all of the sub-packages. This helps preventing the problem that one package might update to a newer version while another one stays at the same, resulting in a conflict.
Test link