Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

this is to allow luca to do screenshots [DO NOT MERGE] #1251

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

this is to allow luca to do screenshots [DO NOT MERGE] #1251

wants to merge 1 commit into from

Conversation

ltkum
Copy link
Contributor

@ltkum ltkum commented Feb 20, 2025 •
edited by github-actions bot
Loading

@cypress Cypress
Copy link

cypress bot commented Feb 20, 2025

web-mapviewer    Run #4614

Run Properties:  status check passed Passed #4614  •  git commit 1df71e66ae: this is to allow luca to do screenshots
Project web-mapviewer
Branch Review do_not_merge_this_branch
Run status status check passed Passed #4614
Run duration 04m 22s
Commit git commit 1df71e66ae: this is to allow luca to do screenshots
Committer Martin Künzi
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 22
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 233
View all changes introduced in this branch ↗︎

pakb
pakb reviewed Feb 20, 2025
View reviewed changes
packages/mapviewer/src/config/staging.config.js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd propose to let use decide to "opt-out" of the "dev site warning" in the DebugToolbar, this way we could check our layout without it whenever we want

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea. i wanted to give Luca a very quick layout so he could make screenshots, but I can adapt that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakb pakb pakb left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE 💣
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ltkum @pakb