Skip to content

Conversation

@ltkum
Copy link
Contributor

@ltkum ltkum commented Nov 17, 2025

Issue: When loading an external WMS layer, the initial values (like the visibility or opacity) were not passed to the layer, which meant that on startup, we would automatically lose their initial state.

Fix: We add the initial values as parameters to the makeExternalWMSLayer function.

Test link

@ltkum ltkum requested a review from pakb November 17, 2025 18:17
@github-actions github-actions bot added the bug label Nov 17, 2025
@cypress
Copy link

cypress bot commented Nov 17, 2025

web-mapviewer    Run #6075

Run Properties:  status check failed Failed #6075  •  git commit a287cb9c75: PB-1383: Avoid concurrency between app setup and URL parsing
Project web-mapviewer
Branch Review fix-PB-1383-no-external-layers-params
Run status status check failed Failed #6075
Run duration 11m 48s
Commit git commit a287cb9c75: PB-1383: Avoid concurrency between app setup and URL parsing
Committer Martin Künzi
View all properties for this run ↗︎

Test results
Tests that failed  Failures 61
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 20
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 116
View all changes introduced in this branch ↗︎

Tests for review

Failed  layers.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  drawing.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  timeSlider.cy.ts • 3 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly part 1 Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly with the timeSlider param at startup Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > behaves correctly when years are being entered in the input Test Replay Screenshots
Failed  featureSelection.cy.ts • 5 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Testing the feature selection > Feature pre-selection in the URL > Synchronise URL and feature selection Test Replay Screenshots
Testing the feature selection > Feature pre-selection in the URL > Adds pre-selected features and verifys the translation of the feature text after changing the language Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select an area to identify features inside it Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can select feature by click, add more feature, and deselect feature Test Replay Screenshots
Testing the feature selection > Feature identification on the map > can print feature information Test Replay Screenshots

The first 5 failed specs are shown, see all 26 specs in Cypress Cloud.

Copy link
Contributor

@pakb pakb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you broke a unit test, please fix it

@ltkum ltkum force-pushed the fix-PB-1383-no-external-layers-params branch 3 times, most recently from 8d8a697 to 6c7fe50 Compare November 24, 2025 07:35
@ltkum ltkum requested a review from pakb November 24, 2025 08:34
@ltkum ltkum force-pushed the fix-PB-1383-no-external-layers-params branch 2 times, most recently from 7c9e72d to a1df253 Compare November 27, 2025 09:50
Issue: When loading an external WMS layer, the initial values (like the visibility or opacity) were not passed to the layer, which meant that on startup, we would automatically lose their initial state.

Fix: We add the initial values as parameters to the `makeExternalWMSLayer` function.
@ltkum ltkum force-pushed the fix-PB-1383-no-external-layers-params branch from a1df253 to 7c4ddd7 Compare November 28, 2025 07:15
Issue: When starting the app for the first time, the URL sync plugin would start
being active before the topics were fully set, causing (mainly) the background layer
parameter to be ignored and replaced with the topic's default one

Fix: The `ConfigLoaded` state now wait for the background layer to be set before
being fulfilled.
@ltkum ltkum force-pushed the fix-PB-1383-no-external-layers-params branch from 7c4ddd7 to a287cb9 Compare November 28, 2025 09:08
@ltkum ltkum requested a review from pakb November 28, 2025 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants