Skip to content

PB-2064: shareshortlink cypress test #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: feat-PB-2027-fix-marker-text-test
Choose a base branch
from
Open

PB-2064: shareshortlink cypress test #1513

wants to merge 3 commits into from

Conversation

@sommerfe
Copy link
Contributor

@sommerfe sommerfe commented Nov 20, 2025 •
edited by github-actions bot
Loading

pakb and others added 3 commits November 20, 2025 08:23
@pakb
PB-2027: only request icon in LARGE size, and resize them with the scale
e3a6230 
icons were doubly scaled because the scale was applied on top of a smaller icon URL. Reverting back to what was the use-case before the TS migration, which is that icons are always requested in the same size to the backend, and are scaled on the map (could we get rid of the scaling on the backend?)
@pakb
PB-2027: fix code so that marker/text test passes
ed1b01c 
simplifying a bit the useFieldValidation composable, and trying to maintain reactivity of props given there, even if it is two components down (EmailInput calls TextInput which calls useFieldValidation)
@sommerfe
PB-2064: fix shareShortLink cypress test
d0e3bf3
@sommerfe sommerfe self-assigned this Nov 20, 2025
@sommerfe sommerfe changed the base branch from develop to feat-PB-2027-fix-marker-text-test November 20, 2025 15:20
@github-actions github-actions bot added the bug label Nov 20, 2025
@pakb pakb force-pushed the feat-PB-2027-fix-marker-text-test branch from ed1b01c to a898578 Compare November 20, 2025 15:27
@cypress
Copy link

cypress bot commented Nov 20, 2025

web-mapviewer    Run #6039

Run Properties:  status check failed Failed #6039  •  git commit d0e3bf33b4: PB-2064: fix shareShortLink cypress test
Project web-mapviewer
Branch Review fix-pb-2064-shareshortlink-cypress-test
Run status status check failed Failed #6039
Run duration 14m 30s
Commit git commit d0e3bf33b4: PB-2064: fix shareShortLink cypress test
Committer Felix Sommer
View all properties for this run ↗︎
Test results
Tests that failed  Failures 92
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 18
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 116
View all changes introduced in this branch ↗︎

Tests for review

Failed  drawing.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  timeSlider.cy.ts • 3 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly part 1 Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > checks that the time slider is functional and behave correctly with the timeSlider param at startup Test Replay Screenshots
Cypress tests covering the time slider, its functionalities and its URL parameter > checking the time slider behavior, both on startup and during use > behaves correctly when years are being entered in the input Test Replay Screenshots
Failed  3d/layers.cy.ts • 10 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Test of layer handling in 3D > add layer from search bar Test Replay Screenshots
Test of layer handling in 3D > sets the opacity to the value defined in the layers URL param or menu UI Test Replay Screenshots
Test of layer handling in 3D > sets the timestamp of a layer when specified in the layers URL param Test Replay Screenshots
Test of layer handling in 3D > reorders visible layers when corresponding buttons are pressed Test Replay Screenshots
Test of layer handling in 3D > add GeoJson layer with opacity from URL param Test Replay Screenshots
Test of layer handling in 3D > removes a layer from the visible layers when the "remove" button is pressed Test Replay Screenshots
Test of layer handling in 3D > uses the 3D configuration of a layer if one exists Test Replay Screenshots
Test of layer handling in 3D > add KML layer from drawing Test Replay Screenshots
Test of layer handling in 3D > Verify layer features in 2D and 3D Test Replay Screenshots
Test of layer handling in 3D > Verify a layer with EPSG:4326(WEBMERCATOR) bounding box in 2D and 3D Test Replay Screenshots
Failed  legacyParamImport.cy.ts • 1 failed test • e2e/chrome/mobile

View Output

Test Artifacts
An uncaught error was detected outside of a test Test Replay Screenshots
Failed  changeLanguage.cy.ts • 3 failed tests • e2e/chrome/mobile

View Output

Test Artifacts
Change language > on startup > should show the correct language if we ask for it, even if the param is in uppercase Test Replay Screenshots
Change language > in mobile view > should change the language Test Replay Screenshots
Change language > in desktop view > should change the language Test Replay Screenshots

The first 5 failed specs are shown, see all 27 specs in Cypress Cloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sommerfe sommerfe

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sommerfe @pakb