-
Notifications
You must be signed in to change notification settings - Fork 9
refactor: Refactor layers to take in Arrow RecordBatch
input, not Table
#148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kylebarron
wants to merge
8
commits into
main
Choose a base branch
from
kyle/record-batch-input
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try setting |
Maybe this is a luma version error? |
The shader hooks are not being installed for some reason. This has happened in the past with packaging issues, it is strange that your changes would break this. Could you try to update to use the latest version of deck.gl? Either 9.1 of 9.2-beta? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactor that originally came out of discussions with @ibgreen about a year ago. Currently, each layer here takes in an
arrow.Table
and will generate one underlying deck.gl layer per underlyingRecordBatch
. With this change, each layer now takes in anarrow.RecordBatch
, and will render exactly one underlying layer (or maybe two, in the case of PolygonLayer which renders both a solid and an outline, but still, bounded).n
, we'd have to backtrack to figure out which input batch is associated with thatn
. So if we had 10 batches of 10 rows each, whenn
is 95 the row would be coming from the last batch of the table. Now this is removed from the layer internals.batches
of a Table themselves to, generating an independent layer for each batch. This also means that the user has to remember to assign a uniqueid
to each layer, such as by concatenating the record batch index to the primary id.Change list
Update all layer types and props to use contiguous buffers as input. That means
arrow.Data
instead ofarrow.Vector
andarrow.RecordBatch
instead ofarrow.Table
.Try to update the geoarrow.point example, though this is currently failing with
I'm probably doing something wrong, maybe in my bundling setup.