Fix phases for background material and plasticity in the grain size material model. #6269
Conversation
| # This test is like grain_size_phase_function.prm, but | ||
| # it additionally enables plastic yielding in the material model. |
There was a problem hiding this comment.
Would it make sense to include the other test? If the only thing you changed is the yielding?
source/material_model/grain_size.cc
Outdated
| @@ -979,10 +978,11 @@ namespace aspect | |||
| phase_function->initialize_simulator (this->get_simulator()); | |||
| phase_function->parse_parameters (prm); | |||
|
|
|||
| std::vector<unsigned int> n_phases_for_each_composition = phase_function->n_phases_for_each_composition(); | |||
| n_phase_transitions = n_phases_for_each_composition[0] - 1; | |||
| // Phase transitions are only supported for the background composition. | |||
There was a problem hiding this comment.
Not sure that's quite the right way to say it. There is not really a background composition. The phase function is only used for the viscosity, and you can't specify different viscosities for the different compositions. So technically, the phase transitions are the same for all compositions.
|
Thanks for the review, I addressed your comments, feel free to take another look. |
|
Your changes look good to me, but your new test fails now |
gassmoeller
force-pushed
the
grain_size_multicomposition
branch
from
27730d1 to
7193986
Compare
|
I think I found it. I forgot to remove the tangential velocity boundary conditions in the reworked test file, so now there were tangential and prescribed boundaries. Let's see if the tester is happy now. |
The implementation of plasticity in the grain size material model currently has minor issues that arise when one tries to use it together with multiple phase transitions and multiple compositions, because the function
drucker_prager_plasticity.compute_drucker_prager_parametersis called with the number of phases instead of the number of phase transitions that it expects (off by one). This leads to triggered asserts no matter how one sets the input parameters.I added a test that fails on the main branch and works with this change.
@jdannberg can you take a look?