Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test to expect warning on vectorLayer export #423

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Feb 3, 2025

Description

Follow up #390

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--423.org.readthedocs.build/en/423/
💡 JupyterLite preview: https://jupytergis--423.org.readthedocs.build/en/423/lite

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/fix-export-test

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Integration tests report: appsharing.space

@arjxn-py
Copy link
Member Author

arjxn-py commented Feb 3, 2025

RTD failing unexpectedly

Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @arjxn-py

The RTD test should be related, but it worth maybe running it again (I don't have permission on this project in RTD).

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit d3eeb82 into geojupyter:main Feb 3, 2025
16 of 17 checks passed
@mfisher87
Copy link
Member

@brichet you have an invite to RTD access in your email! It expires in two weeks. So far, me, Martin, and Greg have maintainer rights and can grant access to others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants