Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-organize docs navigation and add releasing guide #428

Merged
merged 8 commits into from
Feb 4, 2025

Conversation

mfisher87
Copy link
Member

@mfisher87 mfisher87 commented Feb 4, 2025

Description

Resolves #265
Resolves #411

The navigation now has 3 elements: User guide, Contributor guide, and Changelog. Everything is grouped under these categories.

Added a releasing guide based on JupyterLite's.

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--428.org.readthedocs.build/en/428/
💡 JupyterLite preview: https://jupytergis--428.org.readthedocs.build/en/428/lite

@mfisher87 mfisher87 added the documentation Improvements or additions to documentation label Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Binder 👈 Launch a Binder on branch mfisher87/jupytergis/releasing-docs

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Integration tests report: appsharing.space

This is kinda uncool, but at the moment our linter does not allow
absolute links. It makes it much harder to reorganize documentation
files.
@mfisher87
Copy link
Member Author

I wanted to use absolute paths for the image links to make it easier to rearrange documentation in the future. The check-links underlying library https://github.com/jupyterlab/pytest-check-links doesn't support it yet.

@mfisher87 mfisher87 changed the title Re-organize navigation and add releasing guide Re-organize docs navigation and add releasing guide Feb 4, 2025
Copy link
Collaborator

@brichet brichet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mfisher87, this looks great 👍

I just have a minor comment, no a blocker.


install
tutorials/index
features/index
Copy link
Collaborator

@brichet brichet Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced by that features part.
I wonder if we could not have extension and collaboration at top level.

Copy link
Member Author

@mfisher87 mfisher87 Feb 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thought process for this change was that this content (extension and collaboration) fall under the category of "explanation", and the audience is end-users. For that reason I thought (1) these things belong in the user guide; (2) it made sense to group these two things together in a directory where we can continue adding more explanatory content in the future.

What do you think about my reasoning?

Alternatively, what about grouping these documents under a "tour" or "About > Why JGIS?" structure? Some of the wordy content on the document index may also feel at home in a "About" section.

@annefou
Copy link
Contributor

annefou commented Feb 4, 2025

Much cleaner indeed! That's great!

(When we have many more releases, listing all the versions might clutter the main page. But for now, it's definitely not an issue.).
Thank you!

@martinRenou
Copy link
Member

Thanks!

@martinRenou martinRenou merged commit e5ce314 into geojupyter:main Feb 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-organize documentation top-level navigation Create releasing documentation
4 participants