Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in gis_document.py #448

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fix a typo in gis_document.py #448

merged 1 commit into from
Feb 6, 2025

Conversation

brichet
Copy link
Collaborator

@brichet brichet commented Feb 6, 2025

Description

There was a typo in gis_document.py, the expected create_ydoc property was misspelled createydoc.

No idea if there are consequences to that 😃

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--448.org.readthedocs.build/en/448/
💡 JupyterLite preview: https://jupytergis--448.org.readthedocs.build/en/448/lite

@brichet brichet added the bug Something isn't working label Feb 6, 2025
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Binder 👈 Launch a Binder on branch brichet/jupytergis/typo

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@martinRenou martinRenou merged commit c6010b9 into geojupyter:main Feb 6, 2025
17 checks passed
@brichet brichet deleted the typo branch February 6, 2025 13:55
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Integration tests report: appsharing.space

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants