Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update image.jGIS and file handling logic to load correctly #481

Merged
merged 7 commits into from
Feb 20, 2025

Conversation

arjxn-py
Copy link
Member

@arjxn-py arjxn-py commented Feb 20, 2025

Description

image.jGIS was not loading with Failed to add Custom Image Layer: Cannot read properties of undefined (reading 'startsWith')

Checklist

  • PR has a descriptive title and content.
  • PR description contains references to any issues the PR resolves, e.g. Resolves #XXX.
  • PR has one of the labels: documentation, bug, enhancement, feature, maintenance
  • Checks are passing.
    Failing lint checks can be resolved with:
    • pre-commit run --all-files
    • jlpm run lint

📚 Documentation preview: https://jupytergis--481.org.readthedocs.build/en/481/
💡 JupyterLite preview: https://jupytergis--481.org.readthedocs.build/en/481/lite

Copy link
Contributor

Binder 👈 Launch a Binder on branch arjxn-py/jupytergis/image-load

@arjxn-py arjxn-py requested a review from martinRenou February 20, 2025 12:01
@arjxn-py arjxn-py added the documentation Improvements or additions to documentation label Feb 20, 2025
Copy link
Contributor

github-actions bot commented Feb 20, 2025

Integration tests report: appsharing.space

@arjxn-py arjxn-py changed the title Update image.jGIS to load correctly Update image.jGIS and file handling logic to load correctly Feb 20, 2025
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Just have a small request to clean that code :)

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton!!

@martinRenou
Copy link
Member

Fix #457

@martinRenou martinRenou merged commit f83b02a into geojupyter:main Feb 20, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants